Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test code related to migrations #9019

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix test code related to migrations #9019

merged 1 commit into from
Sep 17, 2024

Conversation

tristan957
Copy link
Member

We added another migration in 5876c44, but didn't bump this value. This had no effect, but best to fix it anyway.

We added another migration in 5876c44,
but didn't bump this value. This had no effect, but best to fix it
anyway.

Signed-off-by: Tristan Partin <tristan@neon.tech>
Copy link

github-actions bot commented Sep 17, 2024

4994 tests run: 4830 passed, 0 failed, 164 skipped (full report)


Flaky tests (7)

Postgres 17

Postgres 16

Postgres 15

  • test_ondemand_wal_download_in_replication_slot_funcs: release-arm64

Code coverage* (full report)

  • functions: 32.0% (7413 of 23166 functions)
  • lines: 49.9% (59577 of 119341 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
485f7b0 at 2024-09-17T03:40:04.699Z :recycle:

@tristan957 tristan957 enabled auto-merge (rebase) September 17, 2024 04:04
Copy link
Contributor

@hlinnaka hlinnaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a chance to refactor this somehow, so that we wouldn't need to remember to update this every time a new migration is added?

@tristan957 tristan957 merged commit 6138eb5 into main Sep 17, 2024
81 checks passed
@tristan957 tristan957 deleted the tristan957/migrations branch September 17, 2024 14:56
@tristan957
Copy link
Member Author

Is there a chance to refactor this somehow, so that we wouldn't need to remember to update this every time a new migration is added?

Yes, let me give it some thought, and then I will ping you for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants