-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pageserver: throttling: per-tenant metrics + more metrics to help understand throttle queue depth #9077
Merged
problame
merged 3 commits into
main
from
problame/throttling-improve-observability--part2
Sep 20, 2024
Merged
pageserver: throttling: per-tenant metrics + more metrics to help understand throttle queue depth #9077
problame
merged 3 commits into
main
from
problame/throttling-improve-observability--part2
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
reviewed
Sep 20, 2024
koivunej
approved these changes
Sep 20, 2024
koivunej
reviewed
Sep 20, 2024
koivunej
reviewed
Sep 20, 2024
5072 tests run: 4907 passed, 1 failed, 164 skipped (full report)Failures on Postgres 17
Flaky tests (15)Postgres 17
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
67b280f at 2024-09-20T17:00:33.896Z :recycle: |
problame
added a commit
that referenced
this pull request
Sep 20, 2024
problame
deleted the
problame/throttling-improve-observability--part2
branch
September 20, 2024 16:48
davidgomes
pushed a commit
that referenced
this pull request
Sep 21, 2024
…erstand throttle queue depth (#9077)
problame
added a commit
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an ongoing incident where having deeper insights into the queue depth at the throttle might be helpful.
This PR
On a typical PS, a per-timeline counter costs 4MiB in
/metrics
.So, the toll we take here is quite manageable.
There's probably some CPU overhead to the additional global atomics, haven't measured it. It won't be devastating though, and we have the headroom.