-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): only test num of L1 layers in compaction smoke test #9186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
changed the title
fix(test): only test num of L1 layers in compaction smoke test
fix(test): try to test num of L1 layers in compaction smoke test
Sep 27, 2024
skyzh
changed the title
fix(test): try to test num of L1 layers in compaction smoke test
fix(test): only test num of L1 layers in compaction smoke test
Sep 27, 2024
5022 tests run: 4864 passed, 0 failed, 158 skipped (full report)Flaky tests (2)Postgres 17
Postgres 16
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
2a24091 at 2024-10-02T14:35:45.312Z :recycle: |
VladLazar
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, but looks good to me.
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
skyzh
force-pushed
the
skyzh/fix-compaction-smoke
branch
from
October 1, 2024 21:17
791f9a6
to
e5023ec
Compare
Signed-off-by: Alex Chi Z <chi@neon.tech>
skyzh
force-pushed
the
skyzh/fix-compaction-smoke
branch
from
October 2, 2024 13:42
4a2216b
to
2a24091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
close #9160
For whatever reason, pg17's WAL pattern seems different from others, which triggers some flaky behavior within the compaction smoke test.
Summary of changes
We have a threshold for triggering L0 compaction. In some cases, the test case did not produce enough L0 layers to do a L0 compaction, therefore leaving the layer map with 3+ L0 layers above the L1 layers. This increases the average read depth for the timeline.
Checklist before requesting a review
Checklist before merging