Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new compute metrics to sql exporter #9190

Merged
merged 8 commits into from
Oct 1, 2024
Merged

Conversation

hlinnaka
Copy link
Contributor

@hlinnaka hlinnaka commented Sep 27, 2024

These are the perf counters added in commit 263dfba.

Note: This relies on 'neon' extension version 1.5. The default was bumped to 1.5 in commit d696c41.

Copy link

github-actions bot commented Sep 28, 2024

5048 tests run: 4890 passed, 0 failed, 158 skipped (full report)


Flaky tests (7)

Postgres 17

Postgres 16

  • test_ondemand_wal_download_in_replication_slot_funcs: release-x86-64

Postgres 15

  • test_ondemand_wal_download_in_replication_slot_funcs: release-arm64

Postgres 14

Code coverage* (full report)

  • functions: 31.3% (7489 of 23904 functions)
  • lines: 49.6% (60099 of 121237 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
09f9689 at 2024-10-01T14:32:38.753Z :recycle:

Base automatically changed from bump-neon-extension-version to main September 30, 2024 06:20
@hlinnaka hlinnaka requested review from a team as code owners September 30, 2024 06:20
@hlinnaka hlinnaka requested a review from jcsp September 30, 2024 06:20
These are the perf counters added in commit 263dfba.
I omitted it because I didn't know what it is, but sql_exporter
requires a help text.
Copy link
Contributor

@MMeent MMeent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note also that this needs to update the default Neon extension version to 1.5 if that hasn't been done already

compute/etc/neon_collector.yml Outdated Show resolved Hide resolved
Co-authored-by: Matthias van de Meent <matthias@neon.tech>
@hlinnaka
Copy link
Contributor Author

hlinnaka commented Oct 1, 2024

Note also that this needs to update the default Neon extension version to 1.5 if that hasn't been done already

Yes, that was done in commit d696c41. But good point, I'll call that out in the commit message.

@hlinnaka hlinnaka requested a review from MMeent October 1, 2024 12:23
compute/etc/neon_collector.yml Outdated Show resolved Hide resolved
hlinnaka and others added 2 commits October 1, 2024 15:27
Co-authored-by: Matthias van de Meent <matthias@neon.tech>
@hlinnaka hlinnaka merged commit 0d500bb into main Oct 1, 2024
80 checks passed
@hlinnaka hlinnaka deleted the add-metrics-to-sql-exporter branch October 1, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants