-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new compute metrics to sql exporter #9190
Conversation
4f604d9
to
af2c097
Compare
5048 tests run: 4890 passed, 0 failed, 158 skipped (full report)Flaky tests (7)Postgres 17
Postgres 16
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
09f9689 at 2024-10-01T14:32:38.753Z :recycle: |
These are the perf counters added in commit 263dfba.
I omitted it because I didn't know what it is, but sql_exporter requires a help text.
af2c097
to
78d75a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note also that this needs to update the default Neon extension version to 1.5
if that hasn't been done already
Yes, that was done in commit d696c41. But good point, I'll call that out in the commit message. |
Co-authored-by: Matthias van de Meent <matthias@neon.tech>
These are the perf counters added in commit 263dfba.
Note: This relies on 'neon' extension version 1.5. The default was bumped to 1.5 in commit d696c41.