Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: tweak logging of "became visible" for layers #9224

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Oct 1, 2024

Problem

Recent change to avoid the "became visible" log messages from certain tasks missed a task: the logical size calculation that happens as a child of synthetic size calculation.

Related: #9058

Summary of changes

  • Add OnDemandLogicalSize to the list of permitted tasks for reads making a covered layer visible
  • Tweak the log message to use layer name instead of key: this is more terse, and easier to use when debugging, as one can search for it elsewhere to see when the layer was written/downloaded etc.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Oct 1, 2024
@jcsp jcsp changed the title Jcsp/more became visible pageserver: tweak logging of "became visible" for layers Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

5022 tests run: 4864 passed, 0 failed, 158 skipped (full report)


Flaky tests (2)

Postgres 17

Code coverage* (full report)

  • functions: 31.3% (7486 of 23904 functions)
  • lines: 49.6% (60104 of 121238 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
38fcafe at 2024-10-01T15:02:21.502Z :recycle:

@jcsp jcsp marked this pull request as ready for review October 2, 2024 08:33
@jcsp jcsp requested a review from a team as a code owner October 2, 2024 08:33
@jcsp jcsp requested a review from erikgrinaker October 2, 2024 08:33
@jcsp jcsp merged commit f875e10 into main Oct 2, 2024
88 checks passed
@jcsp jcsp deleted the jcsp/more-became-visible branch October 2, 2024 12:21
koivunej added a commit that referenced this pull request Oct 3, 2024
Address minor technical debt in Layer inspired by #9224:

- layer usage as arg same as in spans
- avoid one Weak::upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants