-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storcon: do timeline creation on all attached location #9237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5111 tests run: 4904 passed, 0 failed, 207 skipped (full report)Flaky tests (6)Postgres 17
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
985de0c at 2024-10-03T11:53:34.556Z :recycle: |
VladLazar
force-pushed
the
vlad/storcon-timeline-crud
branch
2 times, most recently
from
October 2, 2024 12:01
59b3976
to
10e4aa2
Compare
VladLazar
changed the title
[WIP] storcon: do timeline creation on all attached location
storcon: do timeline creation on all attached location
Oct 2, 2024
koivunej
reviewed
Oct 2, 2024
koivunej
reviewed
Oct 2, 2024
koivunej
reviewed
Oct 2, 2024
koivunej
reviewed
Oct 2, 2024
Introduce a `TenantMutationLocations` which will allow us to bundle locations other than the latest one for each shard.
VladLazar
force-pushed
the
vlad/storcon-timeline-crud
branch
from
October 3, 2024 09:15
10e4aa2
to
985de0c
Compare
koivunej
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Creation of a timelines during a reconciliation can lead to unavailability if the user attempts to
start a compute before the storage controller has notified cplane of the cut-over.
Summary of changes
Create timelines on all currently attached locations. For the latest location, we still look
at the database (this is a previously). With this change we also look into the observed state
to find other attached locations.
Related #9144
Checklist before requesting a review
Checklist before merging