Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storcon: do timeline creation on all attached location #9237

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

VladLazar
Copy link
Contributor

@VladLazar VladLazar commented Oct 2, 2024

Problem

Creation of a timelines during a reconciliation can lead to unavailability if the user attempts to
start a compute before the storage controller has notified cplane of the cut-over.

Summary of changes

Create timelines on all currently attached locations. For the latest location, we still look
at the database (this is a previously). With this change we also look into the observed state
to find other attached locations.

Related #9144

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Oct 2, 2024

5111 tests run: 4904 passed, 0 failed, 207 skipped (full report)


Flaky tests (6)

Postgres 17

  • test_ondemand_wal_download_in_replication_slot_funcs: release-x86-64

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 31.3% (7491 of 23896 functions)
  • lines: 49.5% (60123 of 121438 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
985de0c at 2024-10-03T11:53:34.556Z :recycle:

@VladLazar VladLazar force-pushed the vlad/storcon-timeline-crud branch 2 times, most recently from 59b3976 to 10e4aa2 Compare October 2, 2024 12:01
@VladLazar VladLazar changed the title [WIP] storcon: do timeline creation on all attached location storcon: do timeline creation on all attached location Oct 2, 2024
@VladLazar VladLazar marked this pull request as ready for review October 2, 2024 13:08
@VladLazar VladLazar requested a review from a team as a code owner October 2, 2024 13:08
@VladLazar VladLazar merged commit dcf7af5 into main Oct 4, 2024
80 checks passed
@VladLazar VladLazar deleted the vlad/storcon-timeline-crud branch October 4, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants