Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metric name of the 'getpage_wait_seconds_bucket' metric #9242

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

hlinnaka
Copy link
Contributor

@hlinnaka hlinnaka commented Oct 2, 2024

Per convention, histogram buckets have the '_bucket' suffix. I got that wrong in commit 0d500bb.

Fixes #9241

Per convention, histogram buckets have the '_bucket' prefix. I got
that wrong in commit 0d500bb.

Fixes #9241
@tristan957
Copy link
Member

I think you meant suffix instead of prefix, but LGTM.

Copy link

github-actions bot commented Oct 2, 2024

5022 tests run: 4864 passed, 0 failed, 158 skipped (full report)


Flaky tests (8)

Postgres 17

Postgres 16

Postgres 14

Code coverage* (full report)

  • functions: 31.3% (7485 of 23887 functions)
  • lines: 49.6% (60091 of 121239 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
c3e07d6 at 2024-10-02T13:51:48.430Z :recycle:

@hlinnaka hlinnaka merged commit d204489 into main Oct 2, 2024
82 checks passed
@hlinnaka hlinnaka deleted the fix-getpage_wait_seconds_bucket-metric-name branch October 2, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badly named metric getpage_wait_seconds_buckets
3 participants