Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storcon: ignore deleted timelines on new location catch-up #9244

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

VladLazar
Copy link
Contributor

@VladLazar VladLazar commented Oct 2, 2024

Problem

If a timeline was deleted right before waiting for LSNs to catch up before the cut-over,
then we would wait forever.

Summary of changes

Fix the issue and add a test for timeline deletions mid migration.

Related #9144

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@VladLazar VladLazar requested a review from a team as a code owner October 2, 2024 14:01
@VladLazar VladLazar changed the title storcon: storcon: ignore deleted timelines on new location catch-up Oct 2, 2024
@VladLazar VladLazar requested a review from jcsp October 2, 2024 14:02
Copy link

github-actions bot commented Oct 2, 2024

5084 tests run: 4898 passed, 0 failed, 186 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 15

Code coverage* (full report)

  • functions: 31.3% (7485 of 23888 functions)
  • lines: 49.6% (60098 of 121235 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
bb7370f at 2024-10-02T15:47:48.448Z :recycle:

@VladLazar VladLazar merged commit 8dbfda9 into main Oct 2, 2024
80 checks passed
@VladLazar VladLazar deleted the vlad/storcon-fix-lsn-wait branch October 2, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants