-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo.toml: enable sso
for aws-config
#9261
Conversation
Ah that's maybe fallout from #9233 . We want SSO support everywhere, also for usage with the pageserver. Also, we want features to be uniqua over all combinations of crates (that's why we use workspace hack). So it would make sense to not add it to |
(also, you might need to run |
sso
for aws-config
in devsso
for aws-config
sso
for aws-config
sso
for aws-config
Got it, thanks. I moved it into the root |
5058 tests run: 4872 passed, 0 failed, 186 skipped (full report)Flaky tests (3)Postgres 17
Postgres 16
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
568bbed at 2024-10-04T09:27:57.064Z :recycle: |
Problem
The S3 tests couldn't use SSO authentication for local tests against S3.
Summary of changes
Enable the
sso
feature ofaws-config
. Also runcargo hakari generate
which made some updates toworkspace_hack
.Checklist before requesting a review
Checklist before merging