Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml: enable sso for aws-config #9261

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Oct 3, 2024

Problem

The S3 tests couldn't use SSO authentication for local tests against S3.

Summary of changes

Enable the sso feature of aws-config. Also run cargo hakari generate which made some updates to workspace_hack.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@erikgrinaker erikgrinaker self-assigned this Oct 3, 2024
@erikgrinaker erikgrinaker requested a review from a team as a code owner October 3, 2024 13:53
@arpad-m
Copy link
Member

arpad-m commented Oct 3, 2024

Ah that's maybe fallout from #9233 . We want SSO support everywhere, also for usage with the pageserver. Also, we want features to be uniqua over all combinations of crates (that's why we use workspace hack). So it would make sense to not add it to dev-dependencies but to the entry in dependencies.

@arpad-m
Copy link
Member

arpad-m commented Oct 3, 2024

(also, you might need to run cargo hakari generate, it's tested in CI)

@erikgrinaker erikgrinaker changed the title remote_storage: enable sso for aws-config in dev Cargo.lock: enable sso for aws-config Oct 3, 2024
@erikgrinaker erikgrinaker changed the title Cargo.lock: enable sso for aws-config Cargo.toml: enable sso for aws-config Oct 3, 2024
@erikgrinaker
Copy link
Contributor Author

erikgrinaker commented Oct 3, 2024

Got it, thanks. I moved it into the root Cargo.toml, removed another explicit override in storage_scrubber, and reran cargo hakari generate. PTAL.

Copy link

github-actions bot commented Oct 3, 2024

5058 tests run: 4872 passed, 0 failed, 186 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 16

Postgres 14

  • test_ondemand_wal_download_in_replication_slot_funcs: release-x86-64

Code coverage* (full report)

  • functions: 31.3% (7488 of 23897 functions)
  • lines: 49.5% (60127 of 121377 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
568bbed at 2024-10-04T09:27:57.064Z :recycle:

@erikgrinaker erikgrinaker enabled auto-merge (squash) October 4, 2024 08:36
@erikgrinaker erikgrinaker merged commit 60fb840 into main Oct 4, 2024
82 checks passed
@erikgrinaker erikgrinaker deleted the erik/remote-storage-sso branch October 4, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants