Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert hyper and tonic updates #9268

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Revert hyper and tonic updates #9268

merged 2 commits into from
Oct 3, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Oct 3, 2024

Slimmer version of #9262. Only reverts #9234.

There were some errors in staging (PS side):

wal_connection_manager{tenant_id=AAAA shard_id=0000 timeline_id=BBBB}: Attempt #1, failed to subscribe for timeline AAAA/BBBB updates in broker: status: Unavailable, message: "h2 protocol error: http2 error", details: [], metadata: MetadataMap { headers: {} }

SK side errors:

WARN broker: push task failed: status: Unknown, message: "transport error", details: [], metadata: MetadataMap { headers: {} }
Caused by:
    0: transport error
    1: connection error
    2: stream closed because of a broken pipe
WARN broker: discover task failed: status: Unknown, message: "h2 protocol error: error reading a body from connection", details: [], metadata: MetadataMap { headers: {} }
Caused by:
    0: error reading a body from connection
    1: stream closed because of a broken pipe

@arpad-m arpad-m requested a review from a team as a code owner October 3, 2024 16:28
@arpad-m arpad-m requested a review from VladLazar October 3, 2024 16:28
@arpad-m arpad-m enabled auto-merge (squash) October 3, 2024 17:24
@skyzh skyzh mentioned this pull request Oct 3, 2024
5 tasks
Copy link

github-actions bot commented Oct 3, 2024

5058 tests run: 4872 passed, 0 failed, 186 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 16

Code coverage* (full report)

  • functions: 31.3% (7489 of 23897 functions)
  • lines: 49.5% (60133 of 121377 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
fafdb7f at 2024-10-03T17:58:44.284Z :recycle:

@arpad-m arpad-m merged commit e3d6eca into main Oct 3, 2024
79 checks passed
@arpad-m arpad-m deleted the arpad/hyper_broker_revert branch October 3, 2024 18:21
erikgrinaker pushed a commit that referenced this pull request Oct 4, 2024
arpad-m added a commit that referenced this pull request Oct 7, 2024
arpad-m added a commit that referenced this pull request Oct 7, 2024
Update hyper and tonic again in the storage broker, this time with a fix
for the issue that made us revert the update last time.

The first commit is a revert of #9268, the second a fix for the issue.

fixes #9231.
@arpad-m arpad-m mentioned this pull request Oct 8, 2024
7 tasks
@arpad-m
Copy link
Member Author

arpad-m commented Oct 8, 2024

Slack link for posterity: https://neondb.slack.com/archives/C07C3NFFDR6/p1727958810611839

erikgrinaker pushed a commit that referenced this pull request Oct 8, 2024
Update hyper and tonic again in the storage broker, this time with a fix
for the issue that made us revert the update last time.

The first commit is a revert of #9268, the second a fix for the issue.

fixes #9231.
arpad-m added a commit that referenced this pull request Oct 14, 2024
Adds a test for the (now fixed) storage broker limit issue, see #9268
for the description and #9299 for the fix.

Also fix a race condition with endpoint creation/starts running in parallel,
leading to file not found errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants