Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert code copy elimination #53

Closed
s-medvedev opened this issue Jun 15, 2021 · 0 comments
Closed

Revert code copy elimination #53

s-medvedev opened this issue Jun 15, 2021 · 0 comments
Assignees
@s-medvedev

Comments

@s-medvedev
Copy link
Contributor

s-medvedev commented Jun 15, 2021 •
edited
Loading

Problem: Code copy elimination breaks the behavior of the emulator in unexpected situations. The problem is in the implementation, which assumes a rigid arrangement of data in memory.

Solution: Revert code copy elimination.

Possible impact: Contract will take more heap for execution. In any case, we will be within the limits of the testnet.

Reverted PR: neonlabsorg/evm#15 and neonlabsorg/solana-program-library#212
@s-medvedev s-medvedev self-assigned this Jun 15, 2021
@s-medvedev s-medvedev mentioned this issue Jun 15, 2021
Closed
s-medvedev added a commit that referenced this issue Jun 15, 2021
@s-medvedev
Update rust-evm #53
51de075
s-medvedev added a commit that referenced this issue Jun 15, 2021
@s-medvedev
Update rust-evm #53
b93ae22
s-medvedev added a commit that referenced this issue Jun 15, 2021
@s-medvedev
Fix clippy errors #53
51f4b03
s-medvedev added a commit that referenced this issue Jun 15, 2021
@s-medvedev
Update rust-evm to develop #53
133ec55
s-medvedev added a commit that referenced this issue Jun 15, 2021
@s-medvedev
Merge pull request #55 from neonlabsorg/53-revert-code-copy-elimination
e2e88fa 
Revert code copy elimination #53
arkadyone pushed a commit to arkadyone/neon-evm that referenced this issue Nov 25, 2022
@anazarov79
Merge pull request neonevm#53 from neonlabsorg/anazarov-docs
a06798c 
Anazarov docs
BoogVAr pushed a commit that referenced this issue May 17, 2023
@anton-lisanin
Print revert messages to Solana log (#53)
da36a2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s-medvedev s-medvedev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s-medvedev