!!!TASK: Upgrade Behat #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2019
baschny
reviewed
Jan 15, 2019
Closed
kdambekalns
reviewed
Jan 15, 2019
Resources/Private/Tests/Behavior/Features/Bootstrap/FeatureContext.php
Outdated
Show resolved
Hide resolved
|
Distribution that for travis: https://travis-ci.com/johannessteu/neos-development-distribution/builds |
|
All related PR's: |
Adjust travis scripts TASK: test kickstart of behat config TASK: Fix travis ci scripts TASK: Implement correct Context in dummy files Adjust default behat configuration file TASK: Upgrade behat dependenices TASK: Make sure to remove old behat config from dsitri collection when testing Debug TASK: Don’t link package in ci as the includes paths won’t match Install before delete ... Come on travis ... Travis Travis
johannessteu
force-pushed
the
behat-upgrade
branch
from
02ec23f
to
948b3ea
Compare
|
I added a travis-ci.yml to check the kickstart command and actually execute those behat tests: |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades Behat from 2.4 to the latest 3.5.x. This change is breaking as behat changed some things under the hood regarding contexts. Therefore the old FlowContext was refactored to a FlowContextTrait wich can be included in FeatureContexts