[FEATURE] Add permissions check for setfilepermissions.sh #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the setfilepermissions.sh script fails due to wrong file permissions left by the composer installation (missing executable bit). Added the checking of the file's permissions, and correcting the file's permissions if needed.
wexi79
changed the title
| @@ -20,6 +20,10 @@ | |||
| } | |||
|
|
|||
| if (isset($argv[1]) && ($argv[1] === 'typo3.flow:core:setfilepermissions' || $argv[1] === 'flow:core:setfilepermissions' || $argv[1] === 'core:setfilepermissions')) { | |||
| $perms = decoct(fileperms(__DIR__. '/setfilepermissions.sh') & 0777); | |||
| if ($perms != '700'){ | |||
There was a problem hiding this comment.
seems like an indention error.
But apart from that: Instead of checking for 0700 wouldn't an is_executable() check work and be a bit less strict?
There was a problem hiding this comment.
Sorry about the indentation. As for the permissions, setfilepermissions.sh sets it's own mode to 700: "sudo chmod 700 $0" on line 76 so why would we allow it to be anything else?
|
Hey you need to push pull requests to the development repository, this is a read-only repository. See https://github.com/neos/flow-development-collection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the setfilepermissions.sh script fails due to wrong file permissions left by the composer installation (missing executable bit). Added the checking of the file's permissions, and correcting the file's permissions if needed.