FEATURE: Make formState initialization extendable #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellienert
force-pushed
the
feature/simple-form-initializer
branch
from
03e34df
to
024862b
Compare
This adds a mechanism to hook into the form state initialization and define custom initializers. Resolves: #152
daniellienert
force-pushed
the
feature/simple-form-initializer
branch
from
024862b
to
70326e6
Compare
daniellienert
force-pushed
the
feature/simple-form-initializer
branch
2 times, most recently
from
f2e3c72
to
b605f19
Compare
daniellienert
force-pushed
the
feature/simple-form-initializer
branch
from
b605f19
to
a659196
Compare
bwaidelich
reviewed
May 3, 2022
|
@bwaidelich - we decided upon making the initializer configurable via the form definition. This means, it is not simply injectable but would need some type of factory. In this case the formDefinition acts as factory for lots of objects - so this getter fits into the existing architecture. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a mechanism to hook into the form state initialization and define custom initializers.
Resolves: #152