Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] avoid execptions while extracting metadata #2

Conversation

franzkugelmann
Copy link

when extracting data there might occur exceptions because the extracted data does not fit the validation rules. Improved expression to ensure valid data.

@franzkugelmann
Copy link
Author

franzkugelmann commented Aug 30, 2016

just saw that you recently tackled one issue by another way: #1. Please consider our pull request as alternative, i think it solves that issue

@franzkugelmann
Copy link
Author

by the way, see you in Nuernberg tomorrow :)

tags: '${Array.concat(asset.tags || [], iptc.keywords || [])}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this wouldn't fix the problem as the problem occurs when a tag with an empty name is created.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that if i.e. iptc.keywords is an empty string, it results in an array with one empty element resulting in the tried creation of a tag with empty name. It fixed the problem in our real live case. But, nevermind, is already solved in your PR!

@daniellienert
Copy link
Member

Hey Franz,
Thanks a lot for the PR, but as you mentioned I fixed the problem another way - and I see some issues with your commit (see comments)

@daniellienert
Copy link
Member

I'm definitely keen to hear what your real life case is and how we can improve the package. Let's talk about it tomorrow.

ComiR added a commit to ElementareTeilchen/neos.metadata that referenced this pull request Oct 29, 2019
* TASK: NodeType mapping configurable | added more properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants