Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Fix broken XLIFF files #5053

Merged
merged 1 commit into from
May 14, 2024
Merged

BUGFIX: Fix broken XLIFF files #5053

merged 1 commit into from
May 14, 2024

Conversation

kdambekalns
Copy link
Member

See #4921

Review instructions

Weblate should stop complaining…

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@kdambekalns kdambekalns self-assigned this May 14, 2024
dlubitz
dlubitz approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kdambekalns
Copy link
Member Author

I checked it here again, looks good to me, too…

@kdambekalns kdambekalns disabled auto-merge May 14, 2024 15:15
@kitsunet kitsunet closed this May 14, 2024
@kitsunet kitsunet reopened this May 14, 2024
@kitsunet kitsunet merged commit 1388700 into neos:9.0 May 14, 2024
10 of 15 checks passed
@kdambekalns kdambekalns deleted the bugfix/fix-broken-xliff branch May 14, 2024 15:19
@mhsdesign
Copy link
Member

Thank you @kdambekalns for taking care :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlubitz dlubitz dlubitz approved these changes

@kitsunet kitsunet Awaiting requested review from kitsunet

Assignees

@kdambekalns kdambekalns

Labels
9.0 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kdambekalns @mhsdesign @dlubitz @kitsunet