BUGFIX: Exclude shortcuts from XML sitemap #35
Conversation
|
This is one way to fix that… we could avoid adding a new property (and the need for a
What is the way to go? |
|
/cc @TheLalaMan |
|
not really an optimal way to solve the issue, even though the feature isn't such a bad idea in itself how about just skipping shortcuts all together in the sitemap? internal shortcuts would just point to another node anyway, thus unnecessary should be doable by setting a |
|
Heck, this is a way better solution, thanks @aertmann. I felt like I was missing something obvious ;) |
kdambekalns
force-pushed
the
skip-shortcuts
branch
from
815941a
to
a5979f0
Compare
|
That worked for me… :) |
|
No, this does not work as expected, I was too quick with my testing. With this filter, all children of a shortcut node will be skipped as well, thus making whole sections of a website disappear… |
When shortcuts are included in the XML sitemap, that may lead to invalid sitemap entries: If a shortcut points to an external URL, it violates the XML sitemap protocol. Setting the filter property of the used Menu object to exclude Shortcuts does not work as expected, as it would exclude children of those nodes as well. Thus a check in the XML template is used.
kdambekalns
force-pushed
the
skip-shortcuts
branch
from
a5979f0
to
fc6b013
Compare
|
good catch |
|
Now with an |
When shortcuts are included in the XML sitemap, that may lead to
invalid sitemap entries: If a shortcut points to an external URL,
it violates the XML sitemap protocol.