TASK: Get rid of RemoveNode feedback in Move* changes

As it turns out, using nodeAddresses rather than context paths, these feedbacks are no longer necessary.
neos · Jul 10, 2023 · 1375319 · 1375319
1 parent a53af29
commit 1375319
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 9 deletions.
diff --git a/Classes/Domain/Model/Changes/MoveAfter.php b/Classes/Domain/Model/Changes/MoveAfter.php
@@ -88,9 +88,6 @@ public function apply(): void
             $updateParentNodeInfo->setNode($parentNodeOfPreviousSibling);
             $this->feedbackCollection->add($updateParentNodeInfo);
 
-            $removeNode = new RemoveNode($subject, $parentNodeOfPreviousSibling);
-            $this->feedbackCollection->add($removeNode);
-
             $this->finish($subject);
         }
     }

diff --git a/Classes/Domain/Model/Changes/MoveBefore.php b/Classes/Domain/Model/Changes/MoveBefore.php
@@ -87,9 +87,6 @@ public function apply(): void
 
             $this->feedbackCollection->add($updateParentNodeInfo);
 
-            $removeNode = new RemoveNode($subject, $succeedingSiblingParent);
-            $this->feedbackCollection->add($removeNode);
-
             $this->finish($subject);
         }
     }

diff --git a/Classes/Domain/Model/Changes/MoveInto.php b/Classes/Domain/Model/Changes/MoveInto.php
@@ -95,9 +95,6 @@ public function apply(): void
             $updateParentNodeInfo->setNode($parentNode);
             $this->feedbackCollection->add($updateParentNodeInfo);
 
-            $removeNode = new RemoveNode($subject, $parentNode);
-            $this->feedbackCollection->add($removeNode);
-
             $this->finish($subject);
         }
     }