TASK: tslint now prohibits console.x and debugger #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a left-over task from #2128. |
|
Yep! Seems I have broken travis, will fix it tomorrow. |
|
Hey @JamesAlias - master is fixed, could you please rebase your branch? |
JamesAlias
force-pushed
the
tslint-settings
branch
from
7976a0e
to
52d66cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I configured TSLint so that it prohibits
console.xanddebugger.How I did it
I set the corresponding setting to true:
no-console: trueno-debugger: trueHow to verify it
Use
console.login.ts(x)file and runmake lint. It should fail with an error msg.It should not fail when running
make build-watch. So you can still useconsoleanddebuggerwhile developing.