Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Disable asset search through asset editor when media browser is disabled #3536

Conversation

grebaldi
Copy link
Contributor

@grebaldi grebaldi commented Jun 23, 2023

fixes: #1571

The problem

As stated in #1571, even if the media browser has been deactivated via feature-toggle in the asset editor configuration, it is still accessible through search-as-you-type, because the search results are sourced from the media module.

I can very well be argued that by configuring mediaBrowser: false, the integrator's intent is to restrict the asset editor solely to its upload function. At the moment this intent could be bypassed.

The solution

I added code to dynamically disable the asset search in the asset editor depending on the value of the mediaBrowser feature toggle. If mediaBrowser is set to false, search will be disabled as well.

Despite the quick fix, I think we should discuss if we want to consider this the correct way to interpret the feature toggle. (Maybe also use 👍 / 👎 on this description)

@github-actions github-actions bot added Bug Label to mark the change as bugfix 7.3 labels Jun 23, 2023
@markusguenther markusguenther merged commit f5c3c50 into neos:7.3 Dec 18, 2023
1 check passed
@markusguenther
Copy link
Member

Found another little issue while testing. The select box of the multi-select box for the search is not removed for a disabled feature set.
Screenshot 2023-12-18 at 20 25 47

But as this another issue, I will create one and provide an extra fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.3 Bug Label to mark the change as bugfix next-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting mediabrowser to false in File Selection Editor still enables search for existing files
4 participants