Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Translate backend messages #3697

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

pKallert
Copy link
Contributor

@pKallert pKallert commented Jan 25, 2024

What I did
In #3665 we added the Translation trait to the Backend Service Controller.
Currently, only one message is translated in the backend, but we should translate all messages.

@kdambekalns kdambekalns changed the title Task: translate backend messages TASK: Translate backend messages Jun 14, 2024
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

Resources/Private/Translations/en/Main.xlf Show resolved Hide resolved
Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks also good to me by reading.
(if {workspace} really works as placeholder 🤞 )

Copy link
Member

@crydotsnake crydotsnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️

@pKallert pKallert merged commit 56ec023 into neos:9.0 Jun 25, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants