FEATURE: Rewrite NodeType::getName()

[dlubitz]

Rector migration for NodeType::getName removal

neos/neos-development-collection#4560

PHP
$nodeType->getName() to $nodeType->name->value

Fusion
${node.nodeType.name} to ${node.nodeTypeName.value}

Fixes partly #25

[bwaidelich]

I love it, thanks! (+1 by reading)

just a mini question re comment positioning.

Also I wonder: Do all our rector migrations add a "TODO 9.0 migration" prefix?

[ahaeslich]

Also I wonder: Do all our rector migrations add a "TODO 9.0 migration" prefix?

I remember a conversiation that we add this prefix if we can't be sure that the migration would be correct. E.g. if we can't be sure if it is a node.

[ahaeslich]

@dlubitz shouldn't both rules be included in config/set/contentrepository-90.php as you did in #18?

[dlubitz]

@bwaidelich As Anke says, it's on all places where the migrator should have have a look and might need to change something manually.
@ahaeslich You are absolutly right. I added them.