Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments for FusionReplacePrototypeNameRector if needed #51

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Add comments for FusionReplacePrototypeNameRector if needed #51

merged 2 commits into from
Apr 22, 2024

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Apr 21, 2024 •
edited
Loading

  • Add rule for adding comments to Prototype name replacements.
  • Add comment for Neos.Fusion:Collection =>Neos.Fusion:Loop
  • Add comment for Neos.Fusion:RawCollection => Neos.Fusion:Map

@dlubitz dlubitz mentioned this pull request Apr 21, 2024
Merged
bwaidelich
bwaidelich approved these changes Apr 21, 2024
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, +1 by reading

config/set/contentrepository-90.php Outdated Show resolved Hide resolved
@mhsdesign
Copy link
Member

Lovely ;)

@mhsdesign mhsdesign merged commit a73b26c into main Apr 22, 2024
2 checks passed
@kdambekalns kdambekalns deleted the add-comments-for-fusion-prototypes branch May 14, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaidelich bwaidelich bwaidelich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlubitz @mhsdesign @bwaidelich