Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Adjust logger calls for Flow 6.0 #18

Merged
merged 3 commits into from
Sep 4, 2019
Merged

TASK: Adjust logger calls for Flow 6.0 #18

merged 3 commits into from
Sep 4, 2019

Conversation

daniellienert
Copy link
Member

No description provided.

kdambekalns
kdambekalns reviewed Aug 20, 2019
View reviewed changes
composer.json Outdated Show resolved Hide resolved
Classes/Transport/LoggingTransport.php Outdated Show resolved Hide resolved
@kdambekalns
TASK: Rename $systemLogger to $logger
23785a8
@kdambekalns
TASK: Adjust dependency to neos/flow
1be659d 
- the `LogEnvironment` is available as of ^5.2
- allow ^6.0
- allow dev-master
kdambekalns
kdambekalns approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted what I considered "wrong", please check (again).

@daniellienert
Copy link
Member Author

We should generally decide if we go for the | dev-master or require dev-master as [next-version] - I like the latter more.

@daniellienert
Copy link
Member Author

👍 as I cannot review my own PR

@daniellienert daniellienert merged commit 91162e2 into master Sep 4, 2019
@daniellienert daniellienert deleted the task/adjust-logger-for-flow-6 branch September 4, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsunet kitsunet kitsunet left review comments

@kdambekalns kdambekalns kdambekalns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniellienert @kdambekalns @kitsunet