[RFC] Build reports independently and in parallel. #13
Conversation
fwalch
force-pushed
the
independent-reports
branch
from
f70c6ec
to
6405ae0
Compare
fwalch
changed the title
| @@ -1,3 +1,5 @@ | |||
| DOC_SUBTREE="/build-reports/translations/" | |||
There was a problem hiding this comment.
Let's bite the bullet and change these URLs to /reports/foo/. I'll update the website once this is merged.
There was a problem hiding this comment.
If I only change this here, there will be both build-reports and reports directories in neovim/doc. Created neovim/doc#1 to take care of that.
| git commit -m "Documentation: Automatic update." | ||
| git push --force https://${GH_TOKEN}@github.com/${DOC_REPO} ${DOC_BRANCH} | ||
| git commit -m "${REPORT//-/ }: Automatic update." || true # if there are no changes, git commit returns with a non-zero exit code | ||
| until (git pull --rebase origin ${DOC_BRANCH} && git push https://${GH_TOKEN}@github.com/${DOC_REPO} ${DOC_BRANCH}); do echo "Pushing to ${DOC_REPO}."; sleep 1; done |
There was a problem hiding this comment.
Correct me if I'm wrong, but I think this will only echo "Pushing to ${DOC_REPO}." once (or none). The git pull will block until it is finished.
There was a problem hiding this comment.
Oh, I get it now, this is in case it fails :)
Indeed, this is much simpler than I expected. Very nice!
No problem, we'll go with that for now. |
fwalch
force-pushed
the
independent-reports
branch
from
f8a32e2
to
c05f392
Compare
|
One last request: could you add a quick example to |
|
Sure! Just as an aside, I'll try to simplify this to |
fwalch
force-pushed
the
independent-reports
branch
from
c05f392
to
bdbd423
Compare
|
I think I addressed all of your comments. Also changed the logo link to |
fwalch
force-pushed
the
independent-reports
branch
from
bdbd423
to
a172b42
Compare
|
Split into two commits. |
|
Build is here, output in fwalch/doc2. If there are no more comments, I'd say this is ready (neovim/doc#1 needs to be merged first!). |
|
Indeed! Need to update links in https://github.com/neovim/neovim.github.io/blob/master/doc_index.html Planning to do that tonight, didn't want to bug you about it. |
|
@justinmk Had another spare minute, see neovim/neovim.github.io#68 :-) |
Build reports independently and in parallel.
|
😎 |
|
Thanks @justinmk! |
#12 actually didn't comprise that many changes, so I went ahead and implemented it to see if/how it works in reality.
You can see the result at https://github.com/fwalch/doc2/commits/gh-pages (only commits from Aug 20 are relevant). This is the output of two builds, one is at https://travis-ci.org/fwalch/bot-ci/builds/33041843. Note that there is no commit for
doc-index(pull index.html from neovim.org/doc_index), because that file didn't change at all.The only thing I'm not too happy about is the very last line of publish-reports.sh:
Force-pushing will push the full local history, not just the last commit, so I think there is no other way than to update the local clone before pushing. I hope that this is an acceptable "hack", however.