-
Notifications
You must be signed in to change notification settings - Fork 21
[RFC] Refactor into standalone build scripts. #14
Conversation
fc0bc5e
to
2699a13
Compare
# ${BUILD_DIR} | ||
|
||
install_dependencies() { | ||
if [[ ${CI} != true ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This environment variable is set by Travis.
87fe7e2
to
26bc360
Compare
Rebased from master. Now suppresses all output from |
89e68d1
to
fb05b72
Compare
Changed to a more detailed commit message and fixed infinite loops on Travis for You have to add a separate commit to test PRs on Travis; I added instructions for that to the readme. From my point of view, this is ready. |
110a555
to
ea3f2bf
Compare
@justinmk What do you think of this? There are a lot of modified files in this PR, but not that many code changes. I tried to sum them up in the commit message. |
* Enable Travis CI. | ||
* Create a new testing branch based on your PR branch (e.g. `git checkout pr-branch && git checkout -b pr-branch-test`). | ||
* Obtain a [Github personal access token](https://github.com/settings/applications) and encrypt it for Travis using `travis encrypt 'GH_TOKEN=<token>' -r <username>/bot-ci`. | ||
* Modify `.travis.yml` and override environment variables as necessary, e.g.: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice instructions. I learned something :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :-)
* Move build scripts from ./scripts/ to ./ci/. * Overridable environment variables for test builds (see README.md). * Suppress all output from `git push`. * Fix infinite `git push` loop on PR branches.
ea3f2bf
to
f147b05
Compare
Refactor into standalone build scripts.
A build is here, output (from multiple builds) in fwalch/doc2.
From the updated readme:
I think this also improves high-level readability of report generation quite a bit:
Next step is to install only required dependencies for each report (ref #12).