-
Notifications
You must be signed in to change notification settings - Fork 21
[RFC] Add dependency rebuilding (32/64 bit). #20
Conversation
@@ -2,9 +2,10 @@ | |||
|
|||
BUILD_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)" | |||
source ${BUILD_DIR}/ci/common/common.sh | |||
source ${BUILD_DIR}/ci/common/dependencies.sh | |||
source ${BUILD_DIR}/ci/common/neovim.sh | |||
source ${BUILD_DIR}/ci/common/travis-dependencies.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit: Nevermind, I see why you named it like this.travis-deps.sh
?
2e92081
to
1d20f81
Compare
Changed the file names; build is running at https://travis-ci.org/fwalch/bot-ci/builds/35124444. |
1d20f81
to
7742a10
Compare
Added a prompt to push to a repository for local builds and adapted the README. Example commit from a local build: fwalch/neovim-deps@d7dd51b |
I think It's not a huge concern, but I would like to make it easy for other devs to keep up with the changes in bot-ci. |
Hm, my idea was that changing all repository-related library scripts to |
Yeah, but it's not really clear what neovim-repo really means, for example. We need neovim.sh for a number things; yes it comes from a repo, but that isn't really relevant.
I think it should stay |
5d29cc1
to
abb6da0
Compare
Okay, done. Also, if Build is at https://travis-ci.org/fwalch/bot-ci/builds/35143356. |
ec99f59
to
ae3fd5d
Compare
done | ||
} || echo "No changes for ${CI_TARGET//-/ }." | ||
return | ||
} || prompt_key_local "Build finished, do you want to commit and push the results to ${!repo} ${!branch} (change by setting ${repo}/${branch})?" && { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very slick :)
@fwalch I just ran bot-ci and it failed on a few things. I won't be able to investigate for the next few hours. If you have a chance to look at the logs, any idea if this PR will fix it? |
@justinmk The recent directory changes (/32/, /64/) to |
ae3fd5d
to
4f8bbed
Compare
@justinmk Updated with |
echo "${1}" | ||
echo "Press a key to continue, CTRL-C to abort..." | ||
read -n 1 -s | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this return 0/truthy for non-local builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is for things that the user might want to abort locally, but Travis should do in all cases (e.g. https://github.com/neovim/bot-ci/pull/20/files#diff-eb23d815554bddb9ac4f5c48c7f8601fR60).
Add dependency rebuilding (32/64 bit).
Thanks again! |
@justinmk Oh, infinite push loop:
You have about 55 minutes (until Travis aborts/times out the build) to give Marvim write access to |
Thanks for catching that! |
@tarruda @fwalch The vroom tests are failing with this:
Seems like a path might need to be updated in the python-client or in the vroom task for travis? |
Hm, strange.. I ran a build from the |
@fwalch Can you restart that build and see what happens? Something between yesterday and today broke something, somehow. |
When I exit nvim, sometimes I get the following message:
Could it be that it fails trying to log/output this error message (error occurs at |
Good question! I don't see that error, but it could be a clue. |
This has been used to generate neovim/deps#4. Here's a full Travis test build: https://travis-ci.org/fwalch/bot-ci/builds/35124444. Output is in https://github.com/fwalch/deps/tree/testing.