-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
The docu built successfully, although there was a warning regarding sed flags. Should be fixed now. |
That looks great. I noticed a bug: go to http://fwalch.github.io/doc/user/intro.html and click on an option link (eg This bug doesn't happen on http://vimhelp.appspot.com/ so perhaps we should use that python script (source here: https://github.com/c4rlo/vimhelp ) |
@justinmk That bug was actually not the script's fault, but mine. I initially thought that the envsubst problem was caused by quoting issues, so I performed a search-and-replace that ultimately destroyed some links. I removed this (helper functions are now the same as in master, only case-insensitive); all links should now work correctly. A build is currently running. |
Added another commit that replaces |
@fwalch Didn't realize you had fixed the bug. Think this is RDY? |
@justinmk neovim/neovim#1011 will need to be merged first, otherwise I'd say yes. Updated to resolve merge conflicts. |
d4c1220
to
fbfcd26
Compare
} | ||
|
||
# Helper function to extract inline JavaScript from HTML head | ||
# Extract inline JavaScript from HTML file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I guess this still needs neovim/neovim/pull/1011 ? |
Yup. |
Now that neovim/neovim#1011 is in master, this should be ready. |
Yay! |
Looking good :) |
user-docu build failed :
|
Sorry for that; the subtree (sparse) checkout doesn't work if there is no actual subdirectory. See neovim/doc#2. |
With neovim/neovim#1011, HTML user documentation can be generated. If the build passes, the user docu should show up at https://fwalch.github.io/doc/user.
I used a similar approach to the clang report to wrap the docu in Neovim's layout. Unfortunately, the contents of eval.html (9000 lines or so?) were too much for envsubst, so I had to modify
generate_report
to echo the body directly.