Skip to content
This repository has been archived by the owner on Sep 19, 2021. It is now read-only.

[RFC] Push dependency sources to neovim/deps. #57

Closed
wants to merge 1 commit into from

Conversation

fwalch
Copy link
Member

@fwalch fwalch commented May 19, 2015

Added a new build that pushes the sources of the built-in dependencies
to neovim/deps.

This is useful for the Ubuntu PPA, where the sources cannot be
downloaded during the build (no internet connections allowed) and thus
must already be present beforehand. Currently, this is done by manually
updating a Launchpad repository every time one of Neovim's builtin
dependencies is updated (https://code.launchpad.net/~neovim-ppa/neovim-ppa/neovim-deps).

Before this is merged, the src folder needs to be manually created in neovim/deps.

It's a bit of a workaround, since we compile all dependencies and remove the build output afterwards just to get the sources, but on the upside we don't commit sources that won't compile.

ping @justinmk

@fwalch
Copy link
Member Author

fwalch commented May 19, 2015

@fwalch fwalch force-pushed the deps-src.sh branch 4 times, most recently from 22cc7c4 to 61b87c8 Compare May 19, 2015 11:52
@justinmk justinmk self-assigned this May 19, 2015
@fwalch fwalch mentioned this pull request May 20, 2015
26 tasks
@fwalch
Copy link
Member Author

fwalch commented May 20, 2015

If the dependencies didn't change, no new commit will be pushed to the repo:

# On branch master
nothing to commit, working directory clean
No changes for deps src.

Added a new build that pushes the sources of the built-in dependencies
to neovim/deps.

This is useful for the Ubuntu PPA, where the sources cannot be
downloaded during the build (no internet connections allowed) and thus
must already be present beforehand. Currently, this is done by manually
updating a Launchpad repository every time one of Neovim's builtin
dependencies is updated.
@fwalch
Copy link
Member Author

fwalch commented Jun 25, 2015

@fwalch
Copy link
Member Author

fwalch commented Jun 30, 2015

@justinmk Since you self-assigned this issue, any feedback? :-)

@justinmk
Copy link
Member

No, let's do it 👍

@fwalch
Copy link
Member Author

fwalch commented Jun 30, 2015

Should I do the merging/adding the folder to the deps repo?

@justinmk
Copy link
Member

Sure

fwalch added a commit to neovim/deps that referenced this pull request Jun 30, 2015
See neovim/bot-ci#57.
As Git cannot store empty folders, add a placeholder file that will be
overwritten by a subsequent bot-ci build.
fwalch added a commit that referenced this pull request Jun 30, 2015
Added a new build that pushes the sources of the built-in dependencies
to neovim/deps.

This is useful for the Ubuntu PPA, where the sources cannot be
downloaded during the build (no internet connections allowed) and thus
must already be present beforehand. Currently, this is done by manually
updating a Launchpad repository every time one of Neovim's builtin
dependencies is updated.
@fwalch fwalch closed this Jun 30, 2015
@fwalch fwalch deleted the deps-src.sh branch June 30, 2015 18:17
fwalch added a commit to neovim/deps that referenced this pull request Jun 30, 2015
Will be auto-updated by bot-ci; see neovim/bot-ci#57.
fwalch referenced this pull request in neovim/neovim Jun 30, 2015
This avoids messages to stderr about VERSION being missing, and allows
us to skip the autogen step.
fwalch added a commit to fwalch/neovim-deps that referenced this pull request Jul 26, 2015
Will be auto-updated by bot-ci; see neovim/bot-ci#57.
fwalch added a commit to neovim/deps that referenced this pull request Jul 30, 2016
Will be auto-updated by bot-ci; see neovim/bot-ci#57.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants