This repository has been archived by the owner on Sep 19, 2021. It is now read-only.
[RFC] Push dependency sources to neovim/deps. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build at https://travis-ci.org/fwalch/bot-ci/builds/63159062. The output should show up in https://github.com/fwalch/neovim-deps/tree/master/src. |
fwalch
force-pushed
the
deps-src.sh
branch
4 times, most recently
from
22cc7c4
to
61b87c8
Compare
|
If the dependencies didn't change, no new commit will be pushed to the repo: |
Added a new build that pushes the sources of the built-in dependencies to neovim/deps. This is useful for the Ubuntu PPA, where the sources cannot be downloaded during the build (no internet connections allowed) and thus must already be present beforehand. Currently, this is done by manually updating a Launchpad repository every time one of Neovim's builtin dependencies is updated.
|
Rebased. New test build: https://travis-ci.org/fwalch/bot-ci/builds/68282908 (will be pushed to https://github.com/fwalch/neovim-deps/tree/master/src). |
|
@justinmk Since you self-assigned this issue, any feedback? :-) |
|
No, let's do it 👍 |
|
Should I do the merging/adding the folder to the |
|
Sure |
fwalch
added a commit
to neovim/deps
that referenced
this pull request
Jun 30, 2015
See neovim/bot-ci#57. As Git cannot store empty folders, add a placeholder file that will be overwritten by a subsequent bot-ci build.
fwalch
added a commit
that referenced
this pull request
Jun 30, 2015
Added a new build that pushes the sources of the built-in dependencies to neovim/deps. This is useful for the Ubuntu PPA, where the sources cannot be downloaded during the build (no internet connections allowed) and thus must already be present beforehand. Currently, this is done by manually updating a Launchpad repository every time one of Neovim's builtin dependencies is updated.
fwalch
added a commit
to neovim/deps
that referenced
this pull request
Jun 30, 2015
Will be auto-updated by bot-ci; see neovim/bot-ci#57.
fwalch
referenced
this pull request
in neovim/neovim
Jun 30, 2015
This avoids messages to stderr about VERSION being missing, and allows us to skip the autogen step.
fwalch
added a commit
to fwalch/neovim-deps
that referenced
this pull request
Jul 26, 2015
Will be auto-updated by bot-ci; see neovim/bot-ci#57.
fwalch
added a commit
to neovim/deps
that referenced
this pull request
Jul 30, 2016
Will be auto-updated by bot-ci; see neovim/bot-ci#57.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new build that pushes the sources of the built-in dependencies
to neovim/deps.
This is useful for the Ubuntu PPA, where the sources cannot be
downloaded during the build (no internet connections allowed) and thus
must already be present beforehand. Currently, this is done by manually
updating a Launchpad repository every time one of Neovim's builtin
dependencies is updated (https://code.launchpad.net/~neovim-ppa/neovim-ppa/neovim-deps).
Before this is merged, the
srcfolder needs to be manually created inneovim/deps.It's a bit of a workaround, since we compile all dependencies and remove the build output afterwards just to get the sources, but on the upside we don't commit sources that won't compile.
ping @justinmk