Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Small Travis-related improvements. #1570

Merged
merged 5 commits into from
Dec 14, 2014

Conversation

fwalch
Copy link
Member

@fwalch fwalch commented Nov 28, 2014

  • Add install test to 32-bit build.
  • Add flag to force building of dependencies. PRs such as [RFC] Update to libuv 1.0.1. #1542 can temporarily set this to test that using changed third-party dependencies works.

@marvim marvim added the RFC label Nov 28, 2014
@tarruda
Copy link
Member

tarruda commented Nov 29, 2014

👍

@jszakmeister
Copy link
Contributor

I like the spirit of this. It looks like it failed because libtool is missing.

@fwalch fwalch changed the title [RFC] Small Travis-related improvements. [WIP] Small Travis-related improvements. Nov 29, 2014
@marvim marvim added WIP and removed RFC labels Nov 29, 2014
@fwalch fwalch mentioned this pull request Nov 30, 2014
26 tasks
@fwalch fwalch force-pushed the travis-improvements branch 2 times, most recently from 5f71f08 to f8b9e16 Compare December 6, 2014 20:26
@fwalch fwalch force-pushed the travis-improvements branch 8 times, most recently from 031d7b2 to 41adfa5 Compare December 7, 2014 18:55
@fwalch
Copy link
Member Author

fwalch commented Dec 7, 2014

Added another commit to search for core dumps differently (found e.g. ./.deps/build/src/libuv/src/unix/core.c).

@fwalch fwalch force-pushed the travis-improvements branch 6 times, most recently from 052fd33 to 0d65a95 Compare December 8, 2014 13:41
@fwalch fwalch changed the title [WIP] Small Travis-related improvements. [RFC] Small Travis-related improvements. Dec 8, 2014
@fwalch
Copy link
Member Author

fwalch commented Dec 8, 2014

Build works now, so marking RFC. I want to wait for #1572, though, to make sure that building the dependencies works on OS X as well. The Test that setting the deps flag works. commit will be removed after that.

@fwalch
Copy link
Member Author

fwalch commented Dec 13, 2014

Added another commit to not set the core file size, since I've seen the following in build logs:

bash: line 0: ulimit: core file size: cannot modify limit: Operation not permitted

@fwalch
Copy link
Member Author

fwalch commented Dec 14, 2014

I want to wait for #1572, though, to make sure that building the dependencies works on OS X as well.

Reconsidering this, if this PR is merged before #1572, OS X dependency building can just be tested in #1572. So if someone wants to review this PR, please go ahead :-)

The "Test that setting the deps flag works." commit will be removed before setting this RDY.

@@ -4,6 +4,8 @@ os:
env:
global:
- CI_SCRIPTS=$TRAVIS_BUILD_DIR/.ci
# Set to true temporarily to test changes of third-party dependencies.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is somewhat confusing, how about

# To test third-party dependencies, set this to 'true'.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@justinmk
Copy link
Member

Nice changes, LGTM

@justinmk justinmk added the build building and installing Neovim using the provided scripts label Dec 14, 2014
Would otherwise find files in .deps if dependencies are built.
Doesn't work on Travis:

> bash: line 0: ulimit: core file size: cannot modify limit: Operation not permitted
@justinmk
Copy link
Member

The functional tests seem very slow on travis...

@fwalch
Copy link
Member Author

fwalch commented Dec 14, 2014

@justinmk Yes.. I think it depends on the Travis worker, e.g. clang-asan took 15min on master vs 8min in this PR's build (despite this PR building the 3rd party deps as well).

@fwalch
Copy link
Member Author

fwalch commented Dec 14, 2014

The rebased build passed, so I removed the test commit; marking RDY.

@fwalch fwalch changed the title [RFC] Small Travis-related improvements. [RDY] Small Travis-related improvements. Dec 14, 2014
justinmk added a commit that referenced this pull request Dec 14, 2014
@justinmk justinmk merged commit a5edc5f into neovim:master Dec 14, 2014
@justinmk justinmk removed the RFC label Dec 14, 2014
@fwalch fwalch deleted the travis-improvements branch December 14, 2014 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build building and installing Neovim using the provided scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants