-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RDY] Small Travis-related improvements. #1570
Conversation
fwalch
commented
Nov 28, 2014
- Add install test to 32-bit build.
- Add flag to force building of dependencies. PRs such as [RFC] Update to libuv 1.0.1. #1542 can temporarily set this to test that using changed third-party dependencies works.
👍 |
I like the spirit of this. It looks like it failed because libtool is missing. |
5f71f08
to
f8b9e16
Compare
031d7b2
to
41adfa5
Compare
Added another commit to search for core dumps differently (found e.g. |
052fd33
to
0d65a95
Compare
Build works now, so marking RFC. I want to wait for #1572, though, to make sure that building the dependencies works on OS X as well. The |
0d65a95
to
229fc7f
Compare
Added another commit to not set the core file size, since I've seen the following in build logs:
|
Reconsidering this, if this PR is merged before #1572, OS X dependency building can just be tested in #1572. So if someone wants to review this PR, please go ahead :-) The "Test that setting the deps flag works." commit will be removed before setting this RDY. |
@@ -4,6 +4,8 @@ os: | |||
env: | |||
global: | |||
- CI_SCRIPTS=$TRAVIS_BUILD_DIR/.ci | |||
# Set to true temporarily to test changes of third-party dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment is somewhat confusing, how about
# To test third-party dependencies, set this to 'true'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Nice changes, LGTM |
Would otherwise find files in .deps if dependencies are built.
Doesn't work on Travis: > bash: line 0: ulimit: core file size: cannot modify limit: Operation not permitted
229fc7f
to
6b3ad8f
Compare
The functional tests seem very slow on travis... |
6b3ad8f
to
e11a94e
Compare
The rebased build passed, so I removed the test commit; marking RDY. |