-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RDY] Allow running random code on tabline clicks #3871
Conversation
Note that double click will produce two function calls, so the second argument is rather useless. Fixing this is UI layer problem and out of scope of this PR. Vim has the same problem. |
9a020dd
to
947553a
Compare
label, e.g.: %3Xclose%X. Use %999X for a "close current tab" | ||
mark. This information is used for mouse clicks. | ||
T N For 'tabline': start of tab page N label. Use %T or %X to end | ||
the label. This information is used for mouse clicks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This information → The information (or This piece of information)
"This information" is grammatically incorrect, as "information" is always plural in English.
b98717e
to
18364d0
Compare
@@ -4,6 +4,7 @@ | |||
#include "nvim/window.h" | |||
#include "nvim/pos.h" // for linenr_T | |||
#include "nvim/ex_cmds_defs.h" // for exarg_T | |||
#include "nvim/screen.h" // for StlClickRecord |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed by buffer.h directly, shouldn't the various .c file(s) add this include explicitly? ("include-what-you-use")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed by buffer.h because buffer.h.generated.h is considered to be a part of it. AFAIR it was already discussed since declarations generator does not collect needed includes.
@ZyX-I This and other recent PRs failed because of luajit.org connection failures which only affected our builds (seems like they are blocking travis). Rebasing on master will fix this. |
STL_HIGHLIGHT = '#', ///< Highlight name. | ||
STL_TABPAGENR = 'T', ///< Tab page label nr. | ||
STL_TABCLOSENR = 'X', ///< Tab page close nr. | ||
STL_CLICK_FUNC = '@', ///< Click region start. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A full stop (period) at the end of sentence fragments or item lists is not meaningful or useful. Does clint require it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always write what can be considered sentences (absence of action is OK in Russian). Clint does not require this, but I omit a dot only in summaries (for them being taken as “topics”), and write dots otherwise.
18364d0
to
8b3c2d7
Compare
Currently untested and undocumented.
Ping. |
LGTM. |
Allow running random code on tabline clicks
Oh, I forgot to update vim_diff.txt. Though I think I assumed this will be picked up by Vim because *line plugins are pretty popular. |
Agreed. Though we will mention it elsewhere. |
@ZyX-I coverity found this, which appears valid:
|
Intended for status line plugins.
Ref vim-airline/vim-airline#369.