Raise end-index by 1 when setting parts of Range #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherti
changed the title
cherti
changed the title
|
I checked the failed checks of CI, it's flake complaints unrelated to this PR, therefore I'd say this should be ready for merge nevertheless. All tests run through. |
|
could a test be added to |
|
Certainly so. Done. |
This commit fixes a bug in Range, leading to the last line of a Range not being able to be replaced via the __setitem__-function as the final line setting its contents in the buffer the Range is based on assumes the end-index to be inclusive, which it isn't in Python-slicing-notation.
|
PR is updated, One thing that's still bugging me: I cannot reproduce a similar behavior for |
|
@bfredl So if the test is sufficient for you, the PR is final and ready for merge. |
bfredl
added a commit
to bfredl/python-client
that referenced
this pull request
Nov 8, 2017
Brings the client up-to-date with Nvim 0.2.1 Changes since 0.1.13: * a2e1169 Fix tests on windows (neovim#201) * 9a0e729 fix an indexing bug when setting lines in a Range object (neovim#270) * 4abd5d0 Documentation update (neovim#272) * a703b47 make sure logging always uses UTF-8 regardless of locale (neovim#276) * 68aa352 argument to allow nested notification handlers (neovim#262)
bfredl
added a commit
to bfredl/python-client
that referenced
this pull request
Nov 8, 2017
Brings the client up-to-date with Nvim 0.2.1 Changes since 0.1.13: * a2e1169 Fix tests on windows (neovim#201) * 9a0e729 Fix an indexing bug when setting lines in a Range object (neovim#270) * 4abd5d0 Documentation update (neovim#272) * a703b47 Make sure logging always uses UTF-8 regardless of locale (neovim#276) * 68aa352 Argument to allow nested notification handlers (neovim#262)
bfredl
added a commit
to bfredl/python-client
that referenced
this pull request
Nov 8, 2017
Brings the client up-to-date with Nvim 0.2.1 Changes since 0.1.13: * a2e1169 Fix tests on windows (neovim#201) * 9a0e729 Fix an indexing bug when setting lines in a Range object (neovim#270) * 4abd5d0 Documentation update (neovim#272) * a703b47 Make sure logging always uses UTF-8 regardless of locale (neovim#276) * 68aa352 Add argument to allow nested notification handlers (neovim#262)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in Range, leading to the last line of a Range
not being able to be replaced via
__setitem__as the finalline setting its contents in the buffer the Range is based on assumes the
end-index to be inclusive, which it isn't in Python-slicing-notation.
@justinmk