Skip to content

move the gui to a separate repo #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2016
Merged

move the gui to a separate repo #173

merged 1 commit into from
Feb 28, 2016

Conversation

bfredl
Copy link
Member

@bfredl bfredl commented Feb 27, 2016

This seems better than messing with "optional" features and dependencies.
The python-client should focus on being a client library and the provider for python plugins.

a preview of the separate gui repo can be found at https://github.com/neovim/python-gui . It should not be considered "master" until this PR is merged.

Contrary to what I said before, I think it is better to keep the ui_bridge.py along with the gui, as it is not really general but for one specific strategy of integrating the event loops. Other gui implementations can just copy it if they want to reuse it.

@bfredl bfredl mentioned this pull request Feb 27, 2016
@tarruda
Copy link
Member

tarruda commented Feb 27, 2016

Done

The python-client should focus on being a client library and the provider for python plugins.

👍

Ideally the python host should also split into another repository. It adds dependencies like greenlet that are not necessary for simple, non-plugin clients.

@bfredl
Copy link
Member Author

bfredl commented Feb 27, 2016

Ideally the python host should also split into another repository. It adds dependencies like greenlet that are not necessary for simple, non-plugin clients.

Personally I think that is going too far. I suppose almost all users of nvim that would use the python-client in some way, would also expect (legacy or new style) python plugins to work. OTOH quite few that use python plugins would actually use this gui (it doesn't bring that much over a truecolor terminal, but it is nice to have as a simple test gui)

@bfredl
Copy link
Member Author

bfredl commented Feb 27, 2016

Could you turn on travis as well (we don't have tests yet, but lets use flake and the scrutinizer) ?

@tarruda
Copy link
Member

tarruda commented Feb 28, 2016

Could you turn on travis as well (we don't have tests yet, but lets use flake and the scrutinizer) ?

👍

Strangely enough, this repository seem to be deactivated(even though tests are being ran):

travis

@bfredl
Copy link
Member Author

bfredl commented Feb 28, 2016

@tarruda could you change the default branch of python-gui to master ? It would be good to activate the scrutinizer as well.

bfredl added a commit that referenced this pull request Feb 28, 2016
move the gui to a separate repo
@bfredl bfredl merged commit 956f030 into neovim:master Feb 28, 2016
@tarruda
Copy link
Member

tarruda commented Feb 28, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants