Fix 'SyntaxError: invalid syntax' on Python 3.7 alpha pre-release #274

lambdalisue · 2017-10-13T21:47:16Z

Reason

'async' is keyword in Python 3.7

https://www.python.org/dev/peps/pep-0492/#deprecation-plans

justinmk · 2017-10-14T15:59:39Z

neovim/api/buffer.py

        return self.request('nvim_buf_add_highlight', src_id, hl_group,
-                            line, col_start, col_end, async=async)
+                            line, col_start, col_end, _async=_async)


Does the parameter really need to be changed? That's silly, python parser should know the difference.

This will be a breaking change for our users

I machinery replaced all async into _async so I'm not sure about this particular line.
However the screenshot I pasted showed invalid syntax on function attributes and this PR fixed that issue.

justinmk · 2017-10-14T16:03:21Z

I guess we need to detect the python version and show a warning.

lambdalisue · 2017-10-15T02:24:05Z

While Python 3.7 is in alpha stage yet, this PR may not required in future.
I made this PR just for note and users who need Python 3.7 support right now.

bfredl · 2017-10-15T06:24:44Z

So let's wait until python 3.7 is at least in beta. Hopefully they will gather their senses and make it a context-dependent keyword (the pattern used by python in the past). If not, we must keep the existing async keyword for <=3.6 and and use something else for >=3.7, perhaps using a script as part of the build system.

lioumens · 2018-03-03T20:26:21Z

Thanks for the PR @lambdalisue. FYI python 3.7 is now in beta.

bfredl · 2018-03-03T21:08:13Z

Is the breaking change still there? I looked into https://docs.python.org/3.7/whatsnew/3.7.html and grepped for both "async" and "keyword", and found nothing.

Shougo · 2018-03-05T02:09:40Z

@bfredl https://docs.python.org/3.6/whatsnew/3.6.html#new-keywords

It is added in Python 3.6 what's new documentation.

New Keywords
async and await are not recommended to be used as variable, class, function or module names. Introduced by PEP 492 in Python 3.5, they will become proper keywords in Python 3.7. Starting in Python 3.6, the use of async or await as names will generate a DeprecationWarning.

Note: It should be added in Python 3.7 what's new though.

justinmk · 2018-03-05T08:35:46Z

Looks like other popular projects deal with this in the same way. Though async_ (underscore at end) is more common, so let's also use async_.

jdemilledt · 2018-04-12T20:04:26Z

Python 3.7.0b2 still has this issue.

lambdalisue · 2018-04-12T20:38:30Z

Shall I replace _async to async_?

justinmk · 2018-04-12T20:58:30Z

@lambdalisue yes, thanks.

lambdalisue · 2018-04-12T21:33:04Z

Done. It seems tests are failing on master as well so I just ended-up.

Additionally, you said

I guess we need to detect the python version and show a warning.

So I added ~~6d1b28b~~ c421bf5 for backward compatibility. Please revert whenever you satisfied the new API (I'm sorry I found a minor bug on 6d1b28b so I updated forcedly).

justinmk · 2018-04-12T21:41:28Z

neovim/msgpack_rpc/session.py

+            warnings.warn(
+                '"async" attribute is deprecated. Use "async_" instead.',
+                DeprecationWarning,
+            )


This looks like a good solution to me.

If no one else comments, ping in a few days, then we merge.

jdemilledt · 2018-04-12T21:43:03Z

Looks like AppVeyor is drunk.

justinmk · 2018-04-12T22:29:46Z

I broke master when I merged #290 , that's why travis is failing. Fixed by neovim/neovim#8265.

Restarted travis build.

jdemilledt · 2018-04-15T04:59:38Z

@justinmk Ping

bfredl · 2018-04-17T10:07:44Z

neovim/api/buffer.py

        """Add a highlight to the buffer."""
-        if async is None:
-            async = (src_id != 0)
+        if async_ is None and 'async' in kwargs:


This seems like it can be a helper function:
async_ = check_async(async_, kwargs, (src_id != 0))

Should be? It's just one line and used only here so I don't think it's a good idea to extract a simple code into a helper function.

How so? it is 8-9 lines unrelated to the original meaning of the function in at least three places (here, clear_highlight, and request)

I got. Sorry, I thought you are talking about exactly this line.

bfredl · 2018-04-17T10:08:25Z

neovim/msgpack_rpc/event_loop/uv.py

@@ -13,7 +13,7 @@ class UvEventLoop(BaseEventLoop):

    def _init(self):
        self._loop = pyuv.Loop()
-        self._async = pyuv.Async(self._loop, self._on_async)


invalid substitution.

bfredl · 2018-04-17T10:09:00Z

Other than comments, LGTM.

justinmk · 2018-04-16T11:53:50Z

neovim/msgpack_rpc/event_loop/uv.py

@@ -13,7 +13,7 @@ class UvEventLoop(BaseEventLoop):

    def _init(self):
        self._loop = pyuv.Loop()
-        self._async = pyuv.Async(self._loop, self._on_async)
+        self.async_ = pyuv.Async(self._loop, self._on_async)


This is the internal variable name, it should not change.

Always check changes after search-and-replace ...

The README.md (and any other docs) needs to be updated, too.

Always check changes after search-and-replace ...

I'm sorry for that. I didn't realize that there is a private variable for async.
I'll recheck.

The README.md (and any other docs) needs to be updated, too.

Shall I? I'm not native so writing docs is a bit hard for me.

Done by a9a3a70 Is it enough?

lambdalisue · 2018-04-17T15:36:49Z

It seems the highlighted two lines are for private attributes so I renamed these to _async in 5718624

I would like to melt that commit into b7c0d12 once you satisfied that changes.

lambdalisue · 2018-04-17T15:59:06Z

I'll melt 1626e93 into c421bf5 later 👍

'async' is keyword in Python 3.7 https://www.python.org/dev/peps/pep-0492/#deprecation-plans

This commit should be reverted sometime in the future.

lambdalisue · 2018-04-21T18:28:35Z

Done.

jdemilledt · 2018-04-22T17:14:25Z

What release is this planned to be included in?

bfredl · 2018-04-22T17:23:45Z

Unrelated failure (I presume):

FAILED (errors=1)
Exception ignored in: <bound method BaseEventLoop.__del__ of <_UnixSelectorEventLoop running=False closed=True debug=False>>
Traceback (most recent call last):
  File "/opt/python/3.5.5/lib/python3.5/asyncio/base_events.py", line 511, in __del__
  File "/opt/python/3.5.5/lib/python3.5/asyncio/unix_events.py", line 65, in close
  File "/opt/python/3.5.5/lib/python3.5/asyncio/unix_events.py", line 146, in remove_signal_handler
  File "/opt/python/3.5.5/lib/python3.5/signal.py", line 47, in signal
TypeError: signal handler must be signal.SIG_IGN, signal.SIG_DFL, or a callable object

Merged. Thanks @lambdalisue for you work.

bfredl · 2018-04-22T17:28:40Z

@jdemilledt 3.7 final is due to 15 june, we will have a release well before then. If I get around to it I will finish the lua PR #325 next week, and then do a release.

ref #274

This release adds support for Python 3.7 which now is in beta. `async` is a keyword in python3.7, and it should be replaced with `async_` when used as a keyword argument to API methods. `async` is still supported with python 2.7 and 3.6 for the moment, but considered deprecated. Also, integration with the in-process lua interpreter in Nvim is now supported. Changes since 0.2.4: * debcde0 clean up remote object implementation (#313) * e880fe7 Guidelines for local plugin development (#317) * 1ab98e8 Update the working directory on DirChanged for legacy plugins (#296) * d53415d Fix SyntaxError in py3.7: use `async_` instead of `async` (#274) * b65f62d Use `pytest` as `nosetests` are not longer maintained (#266) * d9aed96 Support using lua functions. `buf.update_higlights` as an internal example (#325)

This release adds support for Python 3.7. Previously we didn't allow that version because python-client had problems with it, since arguments were named after keywords newly introduced in 3.7. Fixed since of neovim/pynvim#274

justinmk requested changes Oct 14, 2017

View reviewed changes

bfredl changed the title ~~Fix 'SyntaxError: invalid syntax' on Python 3.7~~ Fix 'SyntaxError: invalid syntax' on Python 3.7 alpha pre-release Oct 15, 2017

bfredl mentioned this pull request Oct 23, 2017

Python 3.7a2: SyntaxError (invalid syntax) #277

Closed

This was referenced Nov 5, 2017

Use of async as a variable name breaks Paramiko in Python 3.7 paramiko/paramiko#1108

Closed

Scheduled daily dependency update on sunday vertexproject/synapse-docker-testimages#37

Closed

mhinz mentioned this pull request Mar 28, 2018

Syntax error with python 3.7 mhinz/neovim-remote#79

Closed

lambdalisue force-pushed the master branch 3 times, most recently from 3b156e7 to 6d1b28b Compare April 12, 2018 21:28

lambdalisue force-pushed the master branch from 6d1b28b to c421bf5 Compare April 12, 2018 21:35

justinmk reviewed Apr 12, 2018

View reviewed changes

bfredl reviewed Apr 17, 2018

View reviewed changes

justinmk reviewed Apr 17, 2018

View reviewed changes

lambdalisue added 2 commits April 22, 2018 03:23

Fix 'SyntaxError: invalid syntax' on Python 3.7

2a0cb3c

'async' is keyword in Python 3.7 https://www.python.org/dev/peps/pep-0492/#deprecation-plans

Allow 'async' for backward-compatibility

2bad222

This commit should be reverted sometime in the future.

lambdalisue force-pushed the master branch from 1626e93 to 2bad222 Compare April 21, 2018 18:24

Replace 'async' in documents to 'async_'

a9a3a70

justinmk approved these changes Apr 22, 2018

View reviewed changes

bfredl merged commit d53415d into neovim:master Apr 22, 2018

FGtatsuro mentioned this pull request Apr 27, 2018

Fix syntax error when python-client is imported on Python 3.7. #330

Merged

justinmk pushed a commit that referenced this pull request Apr 27, 2018

Fix syntax error on Python 3.7 (#330)

eeebcb2

ref #274

mhinz mentioned this pull request Jun 28, 2018

Allow Python 3.7 installation mhinz/neovim-remote#88

Merged

Fix 'SyntaxError: invalid syntax' on Python 3.7 alpha pre-release #274

Fix 'SyntaxError: invalid syntax' on Python 3.7 alpha pre-release #274

Conversation

lambdalisue commented Oct 13, 2017

Reason

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justinmk commented Oct 14, 2017

lambdalisue commented Oct 15, 2017

bfredl commented Oct 15, 2017 • edited

lioumens commented Mar 3, 2018

bfredl commented Mar 3, 2018

Shougo commented Mar 5, 2018

justinmk commented Mar 5, 2018 • edited

jdemilledt commented Apr 12, 2018

lambdalisue commented Apr 12, 2018 • edited

justinmk commented Apr 12, 2018

lambdalisue commented Apr 12, 2018 • edited

Choose a reason for hiding this comment

jdemilledt commented Apr 12, 2018

justinmk commented Apr 12, 2018 • edited

jdemilledt commented Apr 15, 2018

bfredl Apr 17, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bfredl commented Apr 17, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lambdalisue commented Apr 17, 2018

lambdalisue commented Apr 17, 2018

lambdalisue commented Apr 21, 2018

jdemilledt commented Apr 22, 2018

bfredl commented Apr 22, 2018

bfredl commented Apr 22, 2018

bfredl commented Oct 15, 2017 •

edited

justinmk commented Mar 5, 2018 •

edited

lambdalisue commented Apr 12, 2018 •

edited

lambdalisue commented Apr 12, 2018 •

edited

justinmk commented Apr 12, 2018 •

edited

bfredl Apr 17, 2018 •

edited

bfredl commented Apr 17, 2018 •

edited