tests: fix test_command_output #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The `with_setup` decorator does not appear to be designed to be used without parenthesis. Remove it, since it is not needed/used anyway. 2. Fix the actual test.
|
btw: this makes the tests run on pytest. What do you think about using pytest as main test runner? |
Definitely in favor, the work was done in #266 but it's blocked by a build failure that no one has investigated. |
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Apr 12, 2018
This was referenced Apr 12, 2018
justinmk
added a commit
to neovim/neovim
that referenced
this pull request
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with_setupdecorator does not appear to be designed to be usedwithout parenthesis. Remove it, since it is not needed/used anyway.