Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for Neo version 3.4.0 #858

Merged
merged 11 commits into from
Aug 12, 2022
Merged

Updates for Neo version 3.4.0 #858

merged 11 commits into from
Aug 12, 2022

Conversation

mialbu
Copy link
Member

@mialbu mialbu commented Aug 9, 2022

Closes #854
Closes #855
Closes #856

@mialbu mialbu self-assigned this Aug 9, 2022
@mialbu
Copy link
Member Author

mialbu commented Aug 9, 2022

Waiting for release of neo-modules v3.4.0.

@mialbu mialbu requested a review from csmuller August 10, 2022 10:18
@mialbu mialbu marked this pull request as ready for review August 10, 2022 12:50
@mialbu mialbu added this to the v3.19.0 milestone Aug 11, 2022
csmuller
csmuller previously approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@csmuller csmuller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an integration test missing.

BTW, I think there are no breaking changes. Do we need to increment our major number, i.e., from 18 to 19 or can we just do a 18.2

contract/src/main/java/io/neow3j/contract/ContractManagement.java Show resolved Hide resolved
@mialbu
Copy link
Member Author

mialbu commented Aug 12, 2022

BTW, I think there are no breaking changes. Do we need to increment our major number, i.e., from 18 to 19 or can we just do a 18.2

As discussed, we leave it at 19.

@mialbu mialbu requested review from csmuller and removed request for csmuller August 12, 2022 09:05
@mialbu mialbu merged commit d0ecc21 into main Aug 12, 2022
@mialbu mialbu deleted the maintenance/updates-3.4.0 branch August 12, 2022 09:11
@mialbu mialbu mentioned this pull request Aug 12, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csmuller csmuller csmuller approved these changes

Assignees

@mialbu mialbu

Labels
Neo 3.4.0
Projects
None yet
Milestone
v3.19.0
Development

Successfully merging this pull request may close these issues.

Update NEP-11 tracker Update GetNep17Balances Add native method ContractManagement.hasMethod()
2 participants
@mialbu @csmuller