Able to load complex data arrays. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code about the flags introducing at the headers of variables is not clear. Is much clearer when reading header of variables (in loadmat function), and something similar should be done for code clarity.
…ture/complexNumbers
|
Is there a way to achieve this without json-tricks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I modified the code to load and save complex datatype arrays from/to .mat files. When loading, it creates a tuple of python builtin complex values.
I've implemented a test related to complex values, using the same format of the other tests (as close as I could). Now it passes all the tests.
But regarding tests, I had to modify the json module, from "json" to "json-tricks", to be able to serialize complex data, cause the standar json.dumps didn't work with complex numbers. Any problem with that?
Regards,
Ion