Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding versioning support #128

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Conversation

CsatariGergely
Copy link
Contributor

@CsatariGergely CsatariGergely commented May 30, 2024

This change adds a menu to the documentation pointing to the different versions of the deployed documentation set.

Partly fixes #738

This change adds a menu to the documentation pointing to the different
versions of the deployed documentation set.

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Copy link

netlify bot commented May 30, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 0729094
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/66615339f5b58c0008abd1da
😎 Deploy Preview https://deploy-preview-128--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Copy link
Contributor Author

/assign @ciaranjohnston @liamfallon

Copy link
Contributor

@efiacor efiacor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to fix it but the breadcrumbs nav on the R2/3 versions give a 404

Screenshot from 2024-06-06 10-58-37

Screenshot from 2024-06-06 11-00-05

Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with me once the comment from @efiacor is resolved.

This was referenced Jun 12, 2024
@CsatariGergely
Copy link
Contributor Author

Not sure how to fix it but the breadcrumbs nav on the R2/3 versions give a 404

Screenshot from 2024-06-06 10-58-37

Screenshot from 2024-06-06 11-00-05

Uh-oh good catch. This is an issue with the base url setting. I've created separate pr-s for fixing those.
#135
#136

@liamfallon
Copy link
Member

For me this needs docsy 0.10.0, but once that's done, this is working. See #137

@liamfallon
Copy link
Member

/lgtm
/approve

@nephio-prow nephio-prow bot added the lgtm label Jun 13, 2024
Copy link
Contributor

nephio-prow bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 13, 2024
@nephio-prow nephio-prow bot merged commit a404b69 into nephio-project:main Jun 13, 2024
8 checks passed
nephio-prow bot pushed a commit that referenced this pull request Jun 13, 2024
Fixing the 404 issue of the breadcrumb navigation in R2.

/assign @efiacor @liamfallon 

This supposed to fix the issue for the R2 branch pointed out by @efiacor
in
#128 (review)

As an extra I'm adding the link fixes to R2 merged to main in
#130
(69c79e2)

Link checks for the [LFN Wiki](https://wiki.lfnetworking.org/) are
disabled as the wiki is down. [LF IT
ticket](https://jira.linuxfoundation.org/plugins/servlet/desk/portal/2/IT-26874)
was created.

---------

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
nephio-prow bot pushed a commit that referenced this pull request Jun 13, 2024
Fixing the 404 issue of the breadcrumb navigation in R3.

/assign @efiacor @liamfallon 

This supposed to fix the issue for the R3 branch pointed out by @efiacor
in
#128 (review)

As an extra I'm adding the link fixes to R3 merged to main in
#130
(69c79e2)

Link checks for the [LFN Wiki](https://wiki.lfnetworking.org/) are
disabled as the wiki is down. [LF IT
ticket](https://jira.linuxfoundation.org/plugins/servlet/desk/portal/2/IT-26874)
was created.

---------

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants