Fixing links #130
Fixing links #130
Conversation
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Configuration-as-Data definition was copied from https://github.com/kptdev/kpt/blob/main/docs/design-docs/06-config-as-data.md#configuration-as-data-1 Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
✅ Deploy Preview for nephio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
linkspector can not follow the links of images as they are stored in the static directory, but still served from the root path. Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Exclude pattersn for .png images was mailformed Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
- Using a replace pattersn instead of ignore for png images - Fixing more links Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
content/en/docs/glossary.md
Outdated
| manipulating configuration data don’t need to directly interact with storage (git, container images) | ||
|
|
||
| Source of definition and more information about Configuration as Data can be found in the | ||
| [kpt documentation](https://github.com/kptdev/kpt/blob/main/docs/design-docs/06-config-as-data.md#configuration-as-data-1). |
There was a problem hiding this comment.
I know the porch docs are not "ready" but should we link to them instead?
https://github.com/nephio-project/porch/blob/main/docs/06-config-as-data.md
There was a problem hiding this comment.
Oh, yes, definitely. For me it is not really clear where KPT ends and where Porch starts in the documentation.
On the mid term I would like to move the Porch documentation under the Nephio docs (nephio-project/nephio#744). On long term the Porch documentation should follow the code of Porch+
There was a problem hiding this comment.
Fixed in d698826
| @@ -369,6 +369,12 @@ The new cluster comes up after a number of minutes. | |||
|
|
|||
| # Transformations in the Workload cluster creation | |||
|
|
|||
| Test mest | |||
There was a problem hiding this comment.
Just a filler/placeholder?
There was a problem hiding this comment.
Oh, yes, thanks for catching this. I've realized that Docsy does not render the H1 headings to the right side page content list. This is remained after the debugging of the issue. I will try to figure out how to deal with H1 headings and create a PR to fix them in the whole docs set.
There was a problem hiding this comment.
Fixed in d698826
- Pointing to the "new" Porch documentation in the Nephio org - Removal of test text Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
|
@efiacor Can we merge this MR? I suppose it will fix the errors in other MRs. |
|
/assign @efiacor @liamfallon |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixing the 404 issue of the breadcrumb navigation in R2. /assign @efiacor @liamfallon This supposed to fix the issue for the R2 branch pointed out by @efiacor in #128 (review) As an extra I'm adding the link fixes to R2 merged to main in #130 (69c79e2) Link checks for the [LFN Wiki](https://wiki.lfnetworking.org/) are disabled as the wiki is down. [LF IT ticket](https://jira.linuxfoundation.org/plugins/servlet/desk/portal/2/IT-26874) was created. --------- Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Fixing the 404 issue of the breadcrumb navigation in R3. /assign @efiacor @liamfallon This supposed to fix the issue for the R3 branch pointed out by @efiacor in #128 (review) As an extra I'm adding the link fixes to R3 merged to main in #130 (69c79e2) Link checks for the [LFN Wiki](https://wiki.lfnetworking.org/) are disabled as the wiki is down. [LF IT ticket](https://jira.linuxfoundation.org/plugins/servlet/desk/portal/2/IT-26874) was created. --------- Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
No description provided.