Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing base URL for R3 #136

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Conversation

CsatariGergely
Copy link
Contributor

@CsatariGergely CsatariGergely commented Jun 12, 2024

Fixing the 404 issue of the breadcrumb navigation in R3.

/assign @efiacor @liamfallon

This supposed to fix the issue for the R3 branch pointed out by @efiacor in #128 (review)

As an extra I'm adding the link fixes to R3 merged to main in #130 (69c79e2)

Link checks for the LFN Wiki are disabled as the wiki is down. LF IT ticket was created.

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for nephio-r3 ready!

Name Link
🔨 Latest commit 6b58633
🔍 Latest deploy log https://app.netlify.com/sites/nephio-r3/deploys/6669ae4640e2bf0008ee1575
😎 Deploy Preview https://deploy-preview-136--nephio-r3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely CsatariGergely changed the title Fixing base url for R3 Fixing base URL for R3 Jun 12, 2024
Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@nephio-prow nephio-prow bot added the lgtm label Jun 13, 2024
Copy link
Contributor

nephio-prow bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 13, 2024
@nephio-prow nephio-prow bot merged commit d1967ea into nephio-project:R3 Jun 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants