Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing base URL for R2 #135

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

CsatariGergely
Copy link
Contributor

@CsatariGergely CsatariGergely commented Jun 12, 2024

Fixing the 404 issue of the breadcrumb navigation in R2.

/assign @efiacor @liamfallon

This supposed to fix the issue for the R2 branch pointed out by @efiacor in #128 (review)

As an extra I'm adding the link fixes to R2 merged to main in #130 (69c79e2)

Link checks for the LFN Wiki are disabled as the wiki is down. LF IT ticket was created.

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for nephio-r2 ready!

Name Link
🔨 Latest commit 69c79e2
🔍 Latest deploy log https://app.netlify.com/sites/nephio-r2/deploys/6669abbe9a12df000812a3e7
😎 Deploy Preview https://deploy-preview-135--nephio-r2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liamfallon
Copy link
Member

I downloaded this PR to test it but when I ran hugo serve, the result was:

>  hugo serve

Hugo provides its own webserver which builds and serves the site.
While hugo server is high performance, it is a webserver with limited options.

...skipped lines....

Use "hugo server [command] --help" for more information about a command.

Error: command error: Unable to locate config file or config directory. Perhaps you need to create a new site.
Run `hugo help new` for details.

@@ -1,4 +1,4 @@
baseURL = 'https://nephio.org/'
baseURL = 'https://r2.docs.nephio.org/'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these will tie in to the drop down menu when it gets merged right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The drop downs are added in #128 and in #133

@liamfallon
Copy link
Member

I downloaded this PR to test it but when I ran hugo serve, the result was:

>  hugo serve

Hugo provides its own webserver which builds and serves the site.
While hugo server is high performance, it is a webserver with limited options.

...skipped lines....

Use "hugo server [command] --help" for more information about a command.

Error: command error: Unable to locate config file or config directory. Perhaps you need to create a new site.
Run `hugo help new` for details.

Never mind, my mistake, I pulled the wrong PR.

@CsatariGergely CsatariGergely changed the title Fixing base URL Fixing base URL for R2 Jun 12, 2024
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@nephio-prow nephio-prow bot added the lgtm label Jun 13, 2024
Copy link
Contributor

nephio-prow bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 13, 2024
@nephio-prow nephio-prow bot merged commit c92fc73 into nephio-project:R2 Jun 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants