Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add O-RAN Integration documentation #134

Merged
merged 6 commits into from
Jun 28, 2024

Conversation

adetalhouet
Copy link
Member

No description provided.

Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
@nephio-prow nephio-prow bot requested review from s3wong and tliron June 10, 2024 13:14
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit e7d7695
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/667d9d194f4267000842f2c9
😎 Deploy Preview https://deploy-preview-134--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
@adetalhouet adetalhouet changed the title Add approved SIG1 user stories Add O-RAN Integration documentation Jun 27, 2024
@adetalhouet adetalhouet marked this pull request as ready for review June 27, 2024 17:12
Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

nephio-prow bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 28, 2024
@nephio-prow nephio-prow bot merged commit 3badd8a into nephio-project:main Jun 28, 2024
8 checks passed
@adetalhouet adetalhouet deleted the sig1-updates branch June 28, 2024 12:22
@liamfallon
Copy link
Member

I see @tcareyintx made some comments after the PR was merged. @adetalhouet if changes are needed based on @tcareyintx comments, I guess we could raise another PR with those changes.

@adetalhouet
Copy link
Member Author

adetalhouet commented Jun 28, 2024

@tcareyintx Thanks for the review. Unfortunately the PR was merged to soon. I fixed the outstanding comments here #147

nephio-prow bot pushed a commit that referenced this pull request Jun 28, 2024
addresses outstanding comments from
#134

Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants