Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v1.0.0 tag in provision instructions, other doc improvements #39

Merged
merged 4 commits into from
Jul 5, 2023

Conversation

johnbelamaric
Copy link
Member

Looks like I forgot to create a PR for this.

@nephio-prow nephio-prow bot requested review from henderiw and tliron July 5, 2023 17:13
@johnbelamaric johnbelamaric changed the title Doc updates Use v1.0.0 tag in provision instructions, other doc improvements Jul 5, 2023
@johnbelamaric
Copy link
Member Author

Ok, I added the v1.0.0 changes too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line 165: Typo: "pacakge" instead of "package"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line 221: Typo: "usd" instead of "used"

@s3wong
Copy link

s3wong commented Jul 5, 2023

/lgtm
/approve

@nephio-prow nephio-prow bot added the lgtm label Jul 5, 2023
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s3wong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jul 5, 2023
@nephio-prow nephio-prow bot merged commit 4a2489e into nephio-project:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants