Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DOCKER_REGISTRY_MIRRORS environment variable to install script docs #65

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

kispaljr
Copy link
Contributor

Document new DOCKER_REGISTRY_MIRRORS environment variable introduced by nephio-project/test-infra#184

@electrocucaracha
Copy link
Member

/lgtm

@kispaljr
Copy link
Contributor Author

/assign @johnbelamaric

@electrocucaracha
Copy link
Member

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Sep 25, 2023
@electrocucaracha
Copy link
Member

@kispaljr could you rebase this patch in order to be merged?

@kispaljr
Copy link
Contributor Author

kispaljr commented Nov 2, 2023

Rebased it, but now I need an lgtm again, and also an approve

@johnbelamaric
Copy link
Member

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Nov 3, 2023
Copy link
Contributor

nephio-prow bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Nov 3, 2023
@nephio-prow nephio-prow bot merged commit 979c82d into nephio-project:main Nov 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants