Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenStack installation with the overriding method #75

Conversation

electrocucaracha
Copy link
Member

No description provided.

Copy link
Contributor

@lapentad lapentad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Victor, I am getting an error parsing the VCPU

TASK [bootstrap : Checking host has minimum number of CPUS] ********************
Tuesday 28 November 2023 10:23:11 +0000 (0:00:00.052) 0:00:39.916 ******
Tuesday 28 November 2023 10:23:11 +0000 (0:00:00.052) 0:00:39.915 ******
fatal: [127.0.0.1]: FAILED! => {"msg": "The conditional check 'ansible_facts.processor_vcpus >= host_min_vcpu' failed. The error was: Unexpected templating type error occurred on ({% if ansible_facts.processor_vcpus >= host_min_vcpu %} True {% else %} False {% endif %}): '>=' not supported between instances of 'int' and 'str'"}

@electrocucaracha
Copy link
Member Author

Hi Victor, I am getting an error parsing the VCPU

TASK [bootstrap : Checking host has minimum number of CPUS] ******************** Tuesday 28 November 2023 10:23:11 +0000 (0:00:00.052) 0:00:39.916 ****** Tuesday 28 November 2023 10:23:11 +0000 (0:00:00.052) 0:00:39.915 ****** fatal: [127.0.0.1]: FAILED! => {"msg": "The conditional check 'ansible_facts.processor_vcpus >= host_min_vcpu' failed. The error was: Unexpected templating type error occurred on ({% if ansible_facts.processor_vcpus >= host_min_vcpu %} True {% else %} False {% endif %}): '>=' not supported between instances of 'int' and 'str'"}

Interesting, it seems like the value is passed as string, let me try to replicate it in my local environment.

@electrocucaracha
Copy link
Member Author

Hi Victor, I am getting an error parsing the VCPU
TASK [bootstrap : Checking host has minimum number of CPUS] ******************** Tuesday 28 November 2023 10:23:11 +0000 (0:00:00.052) 0:00:39.916 ****** Tuesday 28 November 2023 10:23:11 +0000 (0:00:00.052) 0:00:39.915 ****** fatal: [127.0.0.1]: FAILED! => {"msg": "The conditional check 'ansible_facts.processor_vcpus >= host_min_vcpu' failed. The error was: Unexpected templating type error occurred on ({% if ansible_facts.processor_vcpus >= host_min_vcpu %} True {% else %} False {% endif %}): '>=' not supported between instances of 'int' and 'str'"}

Interesting, it seems like the value is passed as string, let me try to replicate it in my local environment.

I found the issue, I was using the --extra-vars Ansible flag in a wrong way, I have submitted the fix

Signed-off-by: Victor Morales <v.morales@samsung.com>
@lapentad
Copy link
Contributor

/approve

Copy link
Contributor

nephio-prow bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lapentad
Once this PR has been reviewed and has the lgtm label, please assign s3wong for approval by writing /assign @s3wong in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CsatariGergely
Copy link
Contributor

@electrocucaracha we did a quite big refactoring of the documentation structure. Would you like to update this pr to follow the new structure or is it okay if I reimplement it in a new pr?

@lapentad
Copy link
Contributor

Hi @electrocucaracha and @CsatariGergely I created the new pr #81

@lapentad
Copy link
Contributor

Hi @electrocucaracha and @CsatariGergely I created the new pr #81

This pr can be abandoned, because #81 is meant to fix it

@electrocucaracha
Copy link
Member Author

Closing this in favor of #81

nephio-prow bot pushed a commit that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants