Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reordering installation guides #87

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

spaitsbence
Copy link
Contributor

No description provided.

Copy link

linux-foundation-easycla bot commented Jan 24, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Contributor

nephio-prow bot commented Jan 24, 2024

Hi @spaitsbence. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CsatariGergely
Copy link
Contributor

/assign @s3wong
/assign @efiacor

@liamfallon
Copy link
Member

/ok-to-test

@liamfallon
Copy link
Member

/approve

@nephio-prow nephio-prow bot added the approved label Jan 25, 2024
@liamfallon
Copy link
Member

Could we get another "approve" on this PR please?

Copy link
Contributor

@efiacor efiacor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the new weighting actually do? Could you explain?

@CsatariGergely
Copy link
Contributor

What does the new weighting actually do? Could you explain?

yes, it reorders the documents in the left side menu. In this case from the order in the left to the order in the right here:
image

@efiacor
Copy link
Contributor

efiacor commented Jan 26, 2024

What does the new weighting actually do? Could you explain?

yes, it reorders the documents in the left side menu. In this case from the order in the left to the order in the right here: image

Ok. Thanks.
Maybe not for this PR but would it make sense to group some of the install guides into sub sections? The big list doesn't look great imho.

@efiacor
Copy link
Contributor

efiacor commented Jan 26, 2024

/approve

Copy link
Contributor

nephio-prow bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liamfallon
Copy link
Member

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jan 26, 2024
@nephio-prow nephio-prow bot merged commit 4be361c into nephio-project:main Jan 26, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants