Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linkcheck GitHub workflow #91

Merged
merged 9 commits into from
Jan 30, 2024
Merged

Conversation

CsatariGergely
Copy link
Contributor

@CsatariGergely CsatariGergely commented Jan 24, 2024

Adding a linkcheck workflow based on linkspector.
At the moment there are some issues with specifying the ignore list mentioned in UmbrellaDocs/linkspector#16

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Copy link
Contributor

nephio-prow bot commented Jan 24, 2024

Hi @CsatariGergely. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CsatariGergely
Copy link
Contributor Author

/hold

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Copy link
Contributor Author

/unhold

@CsatariGergely CsatariGergely changed the title WIP: Add linkcheck GitHub workflow Add linkcheck GitHub workflow Jan 25, 2024
@CsatariGergely
Copy link
Contributor Author

/assign @liamfallon
/assign @tliron

@liamfallon
Copy link
Member

/ok-to-test

@efiacor
Copy link
Contributor

efiacor commented Jan 26, 2024

/approve

@nephio-prow nephio-prow bot added the approved label Jan 26, 2024
@liamfallon
Copy link
Member

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jan 26, 2024
@liamfallon
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@radoslawc
Copy link
Contributor

/test all

@tliron tliron merged commit b1b2cf3 into nephio-project:main Jan 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants