Update UPFDeployment pods on a config-map update. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s3wong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of configuration changes in UPF. 101
In case of config-map update, we update an Annotation in Spec.Template.Annotations that trigger a deployment rolling update.
For the time being, we update the existing config map rather than creating a new one. The best practice described below is a subject for R2 or further releases.
Per John:
The best practice would be to create separate ConfigMap as they change. Then, you update the ConfigMap that the deployment volume refers to, which automatically does the rolling update.
By doing this, we ensure that the old replica set doesn't pick up the new ConfigMap. So, if the old Pod restarts, it still has the old config.