nephio-controller-manager operator #208
Conversation
Signed-off-by: ssharmasandeep <ssharma@aarnanetworks.com>
Signed-off-by: ssharmasandeep <ssharma@aarnanetworks.com>
Signed-off-by: ssharmasandeep <ssharma@aarnanetworks.com>
Signed-off-by: ssharmasandeep <ssharma@aarnanetworks.com>
| @@ -19,12 +19,15 @@ package ctrlrconfig | |||
| import ( | |||
| "time" | |||
|
|
|||
| "github.com/henderiw-nephio/nephio-controllers/pkg/giteaclient" | |||
There was a problem hiding this comment.
What's this package, should it be in a nephio repo?
There was a problem hiding this comment.
Yes . Changed tjhis to "github.com/nephio-project/nephio/controllers/pkg/giteaclient".
… then we will use it Signed-off-by: ssharmasandeep <ssharma@aarnanetworks.com>
Signed-off-by: ssharmasandeep <ssharma@aarnanetworks.com>
|
Ok, thanks. That looks good but I would like another set of eyes on it. |
|
Thanks @ssharmasandeep . Overall looks good. Can you please add a unit test to have some coverage? |
|
Bala, this is not complete functionality. I will add unit tests in
subsequent PRs in which we start registering controllers with this operator.
-Sandeep
…On Fri, 19 May 2023 at 1:01 AM, Bala Varadaraju ***@***.***> wrote:
Thanks @ssharmasandeep <https://github.com/ssharmasandeep> . Overall
looks good. Can you please add a unit test to have some coverage?
—
Reply to this email directly, view it on GitHub
<#208 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFLUH4MLY3DBDUJRGWW6DLXGZ2KTANCNFSM6AAAAAAYGOR6BM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
/approve |
|
/test presubmit-nephio-go-test |
Signed-off-by: ssharmasandeep <ssharma@aarnanetworks.com>
Signed-off-by: ssharmasandeep <ssharma@aarnanetworks.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: henderiw, johnbelamaric The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR has the operator nephio-controller-manager.
Since we have to create PR one go.mod change at a time, the subsequent PRs post this will have the controllers registered
with the main operator manager.