Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for installing nonKIND cluster via kubeadm #46

Closed
wants to merge 0 commits into from
Closed

add support for installing nonKIND cluster via kubeadm #46

wants to merge 0 commits into from

Conversation

vjayaramrh
Copy link
Collaborator

allows for installing nonKIND K8S cluster on ubuntu and fedora for e2e test cases

@electrocucaracha
Copy link
Member

There are several things to consider for this approach:

radoslawc
radoslawc reviewed May 25, 2023
View reviewed changes
Copy link
Collaborator

@radoslawc radoslawc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

e2e/provision/vars/kubeadm.yaml Outdated
@@ -0,0 +1,9 @@
containerd_ver: 1.6.19
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that those are in vars file, gj

@nephio-prow nephio-prow bot added the approved label May 25, 2023
@vjayaramrh
Copy link
Collaborator Author

There are several things to consider for this approach:

* Maintenance: There are [plenty of mature options](https://www.cncf.io/certification/software-conformance/) to deploy production-ready Kubernetes clusters. [Kubespray](https://kubespray.io/#/) has been used by several projects, but we can make a deep analysis on others.

* Cluster API support: Using non-KinD cluster will result in a different [Infrastructure Cluster API provider](https://cluster-api.sigs.k8s.io/reference/providers.html).

@electrocucaracha Great points, This is now a first step and we should definitely iterate to get there.

@radoslawc
Copy link
Collaborator

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jun 13, 2023
@electrocucaracha
Copy link
Member

electrocucaracha commented Jun 13, 2023 •
edited
Loading

/hold

This needs more discussion and input from others

@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Jun 7, 2024

New changes are detected. LGTM label has been removed.

@nephio-prow nephio-prow bot removed the lgtm label Jun 7, 2024
@vjayaramrh vjayaramrh force-pushed the kubeadm branch 2 times, most recently from 6f6eab2 to 83f86fd Compare June 18, 2024 00:34
@dkosteck dkosteck mentioned this pull request Jun 25, 2024
Closed
dkosteck
dkosteck suggested changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@dkosteck dkosteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes noted per testing on Fedora 34, including the change to the Kubernetes repo source and versioning. Either the k8s_ver flag should be removed as suggested, or a higher version that is supported on Fedora should be used for this flag

e2e/provision/roles/deploy_kubeadm_k8s/tasks/kubeadm-RedHat.yaml Outdated Show resolved Hide resolved
e2e/provision/roles/deploy_kubeadm_k8s/tasks/kubeadm-RedHat.yaml Outdated Show resolved Hide resolved
dkosteck
dkosteck suggested changes Aug 7, 2024
View reviewed changes
e2e/provision/vars/kubeadm.yaml Outdated Show resolved Hide resolved
@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Aug 15, 2024

@vjayaramrh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
provision-linter b7799f6 link true /test provision-linter
install-integration b7799f6 link true /test install-integration
kpt-integration b7799f6 link true /test kpt-integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dkosteck dkosteck closed this Aug 15, 2024
@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: radoslawc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot removed the approved label Aug 15, 2024
@dkosteck dkosteck mentioned this pull request Aug 15, 2024
Merged
nephio-prow bot pushed a commit that referenced this pull request Aug 20, 2024
@dkosteck @vjayaramrh
add support for installing nonKIND cluster via kubeadm (previously PR #…
4a828c2 
…46) (#296)

* add support for installing nonKIND cluster via kubeadm

allows for installing nonKIND K8S cluster on ubuntu and fedora for e2e test cases

* Add support for installing nonKIND cluster via kubeadm, moving file locations

Co-authored-by: Vishwanath Jayaraman <vjayaram@redhat.com>

* Change yml file suffix in main

---------

Co-authored-by: vjayaramrh <vjayaram@redhat.com>
vjayaramrh added a commit to vjayaramrh/test-infra that referenced this pull request Aug 20, 2024
@dkosteck @vjayaramrh
add support for installing nonKIND cluster via kubeadm (previously PR n…
8e07fa9 
…ephio-project#46) (nephio-project#296)

* add support for installing nonKIND cluster via kubeadm

allows for installing nonKIND K8S cluster on ubuntu and fedora for e2e test cases

* Add support for installing nonKIND cluster via kubeadm, moving file locations

Co-authored-by: Vishwanath Jayaraman <vjayaram@redhat.com>

* Change yml file suffix in main

---------

Co-authored-by: vjayaramrh <vjayaram@redhat.com>
nephio-prow bot pushed a commit that referenced this pull request Aug 22, 2024
@vjayaramrh @dkosteck
adds prow job to install nephio components on kubeadm cluster (#297)
f90ff7b 
* add support for installing nonKIND cluster via kubeadm

allows for installing nonKIND K8S cluster on ubuntu and fedora for e2e test cases

* Add support for installing nonKIND cluster via kubeadm, moving file locations

Co-authored-by: Vishwanath Jayaraman <vjayaram@redhat.com>

* adds prow job to install Nephio components on kubeadm cluster

Co-authored-by: Daniel Kostecki <dkosteck@redhat.com>

* add support for installing nonKIND cluster via kubeadm (previously PR #46) (#296)

* add support for installing nonKIND cluster via kubeadm

allows for installing nonKIND K8S cluster on ubuntu and fedora for e2e test cases

* Add support for installing nonKIND cluster via kubeadm, moving file locations

Co-authored-by: Vishwanath Jayaraman <vjayaram@redhat.com>

* Change yml file suffix in main

---------

Co-authored-by: vjayaramrh <vjayaram@redhat.com>

* adds prow job to install nephio components on kubeadm cluster

Co-authored-by: Daniel Kostecki <dkosteck@redhat.com>

---------

Co-authored-by: Daniel Kostecki <dkosteck@redhat.com>
Co-authored-by: Daniel Kostecki <84861140+dkosteck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radoslawc radoslawc radoslawc left review comments

@dkosteck dkosteck dkosteck requested changes

@aravind254 aravind254 Awaiting requested review from aravind254

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@rravindran123 rravindran123 Awaiting requested review from rravindran123

Assignees

@radoslawc radoslawc

Labels
do-not-merge/hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vjayaramrh @electrocucaracha @radoslawc @dkosteck